You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seata.apache.org by "smiletrl (via GitHub)" <gi...@apache.org> on 2024/01/28 05:51:48 UTC
[PR] update depreciated undo log-serialization config [incubator-seata-go-samples]
smiletrl opened a new pull request, #47:
URL: https://github.com/apache/incubator-seata-go-samples/pull/47
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
undo config log-serialization `jackson` is depreciated, change it to default `json`
**Which issue(s) this PR fixes**:
Fixes #
**The related PR of seata-go**
https://github.com/apache/incubator-seata-go/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] update depreciated undo log-serialization config [incubator-seata-go-samples]
Posted by "wt-better (via GitHub)" <gi...@apache.org>.
wt-better commented on code in PR #47:
URL: https://github.com/apache/incubator-seata-go-samples/pull/47#discussion_r1469021993
##########
conf/seatago.yml:
##########
@@ -59,7 +59,7 @@ seata:
# Judge whether the before image and after image are the same，If it is the same, undo will not be recorded
data-validation: true
# Serialization method
- log-serialization: jackson
Review Comment:
`log-serialization` is implementation of json on 'java' ,
If you need to modify this, I suggest changing the meaning or discarding this configuration in seata-go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] update depreciated undo log-serialization config [incubator-seata-go-samples]
Posted by "smiletrl (via GitHub)" <gi...@apache.org>.
smiletrl commented on code in PR #47:
URL: https://github.com/apache/incubator-seata-go-samples/pull/47#discussion_r1469691569
##########
conf/seatago.yml:
##########
@@ -59,7 +59,7 @@ seata:
# Judge whether the before image and after image are the same，If it is the same, undo will not be recorded
data-validation: true
# Serialization method
- log-serialization: jackson
Review Comment:
`json` is one json parser, https://github.com/apache/incubator-seata-go/blob/master/pkg/datasource/sql/undo/parser/parser_json.go.
The current implementation does support adding more `UndoLogParser`. Other than discarding this configuration, I feel we may rename it to `log-parser` to keep this flexibility.
To achieve this, we may also need to add something like below at `pkg/datasource/sql/undo/parser` at `seata-go`
```
parser.RegisterParser()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org
Re: [PR] update depreciated undo log-serialization config [incubator-seata-go-samples]
Posted by "smiletrl (via GitHub)" <gi...@apache.org>.
smiletrl closed pull request #47: update depreciated undo log-serialization config
URL: https://github.com/apache/incubator-seata-go-samples/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@seata.apache.org
For additional commands, e-mail: dev-help@seata.apache.org