You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Alan Woodward (JIRA)" <ji...@apache.org> on 2015/10/19 22:39:27 UTC

[jira] [Updated] (LUCENE-6845) Merge Spans and SpanScorer

     [ https://issues.apache.org/jira/browse/LUCENE-6845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Woodward updated LUCENE-6845:
----------------------------------
    Attachment: LUCENE-6845.patch

Patch.

Spans is merged entirely into SpanScorer, various classes get renamed, and SpanWeight.getSpans() becomes SpanWeight.getSpanScorer().  The only slightly messy part concerns how to pass SimScorers around, as SpanScorer now takes one in its constructor.

Span tests pass, but I still need to run the whole test suite, so health warnings apply.

> Merge Spans and SpanScorer
> --------------------------
>
>                 Key: LUCENE-6845
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6845
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>             Fix For: Trunk, 5.4
>
>         Attachments: LUCENE-6845.patch
>
>
> SpanScorer and Spans currently share the burden of scoring span queries, with SpanScorer delegating to Spans for most operations.  Spans is essentially a Scorer, just with the ability to iterate through positions as well, and no SimScorer to use for scoring.  This seems overly complicated.  We should merge the two classes into one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org