[GitHub] [hive] kgyrtkirk commented on a change in pull request #2546: HIVE-25405 : Implement Connector Provider for Amazon Redshift

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2546:
URL: https://github.com/apache/hive/pull/2546#discussion_r750441378



##########
File path: ql/src/test/queries/clientpositive/redshift_data_connector.q
##########
@@ -0,0 +1,65 @@
+-- SORT_QUERY_RESULTS
+SHOW CONNECTORS;
+
+-- CREATE with comment
+CREATE CONNECTOR redshift_test
+TYPE 'redshift'
+URL 'jdbc:redshift://redshift-cluster-1.c1gffkxfot1v.us-east-2.redshift.amazonaws.com:5439/dev'

Review comment:
       this seems like an external resource - that's not something we should have in a unit test
   

##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/PostgreSQLConnectorProvider.java
##########
@@ -12,7 +12,7 @@
 import java.util.List;
 
 public class PostgreSQLConnectorProvider extends AbstractJDBCConnectorProvider {
-  private static Logger LOG = LoggerFactory.getLogger(MySQLConnectorProvider.class);
+  private static Logger LOG = LoggerFactory.getLogger(PostgreSQLConnectorProvider.class);

Review comment:
       lol :D




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org