You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Anton Tagunov (JIRA)" <ji...@codehaus.org> on 2005/11/23 19:10:06 UTC

[jira] Created: (MAVEN-1730) Autoset MAVEN_HOME on Win32

Autoset MAVEN_HOME on Win32
---------------------------

         Key: MAVEN-1730
         URL: http://jira.codehaus.org/browse/MAVEN-1730
     Project: Maven
        Type: Improvement
  Components: core  
 Environment: Windows
    Reporter: Anton Tagunov
 Attachments: maven.bat.diff

I've had this put into ant.bat, now let's put it into maven.bat Here's how to see my patch usefullness:

Run on Windows.
Set JAVA_HOME.
Add maven/bin added to %PATH%.
Do not set MAVEN_HOME.
Type maven -v

Before my patch: ERROR: MAVEN_HOME not found in your environment.
After my patch: maven run proceeds, MAVEN_HOME set to maven/bin/..

P.S. Have got an apache account, atagunov, but not ready to apply other patches, at least right now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MAVEN-1730) Autoset MAVEN_HOME on Win32

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MAVEN-1730?page=comments#action_51832 ] 

Arnaud Heritier commented on MAVEN-1730:
----------------------------------------

Are you sure it works with all windows versions ?
I didn't remember when variables like %~dp0.. were added.

> Autoset MAVEN_HOME on Win32
> ---------------------------
>
>          Key: MAVEN-1730
>          URL: http://jira.codehaus.org/browse/MAVEN-1730
>      Project: Maven
>         Type: Improvement
>   Components: core
>  Environment: Windows
>     Reporter: Anton Tagunov
>  Attachments: maven.bat.diff
>
>
> I've had this put into ant.bat, now let's put it into maven.bat Here's how to see my patch usefullness:
> Run on Windows.
> Set JAVA_HOME.
> Add maven/bin added to %PATH%.
> Do not set MAVEN_HOME.
> Type maven -v
> Before my patch: ERROR: MAVEN_HOME not found in your environment.
> After my patch: maven run proceeds, MAVEN_HOME set to maven/bin/..
> P.S. Have got an apache account, atagunov, but not ready to apply other patches, at least right now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MAVEN-1730) Autoset MAVEN_HOME on Win32

Posted by "Anton Tagunov (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MAVEN-1730?page=all ]

Anton Tagunov updated MAVEN-1730:
---------------------------------

    Attachment: maven.bat.2.diff

Arnaud, it's a 100% hit. On my way home yesterday I remembered that it won't work on win98.
But it does work on NT.
How about maven.bat.2.diff patch?
Now it's exactly the same logic as for ant.bat.

> Autoset MAVEN_HOME on Win32
> ---------------------------
>
>          Key: MAVEN-1730
>          URL: http://jira.codehaus.org/browse/MAVEN-1730
>      Project: Maven
>         Type: Improvement
>   Components: core
>  Environment: Windows
>     Reporter: Anton Tagunov
>  Attachments: maven.bat.2.diff, maven.bat.diff
>
>
> I've had this put into ant.bat, now let's put it into maven.bat Here's how to see my patch usefullness:
> Run on Windows.
> Set JAVA_HOME.
> Add maven/bin added to %PATH%.
> Do not set MAVEN_HOME.
> Type maven -v
> Before my patch: ERROR: MAVEN_HOME not found in your environment.
> After my patch: maven run proceeds, MAVEN_HOME set to maven/bin/..
> P.S. Have got an apache account, atagunov, but not ready to apply other patches, at least right now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MAVEN-1730) Autoset MAVEN_HOME on Win32

Posted by "Anton Tagunov (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MAVEN-1730?page=all ]

Anton Tagunov updated MAVEN-1730:
---------------------------------

    Attachment: maven.bat.3.diff

Or to be even on a safer side, could do like mvn.bat does. Now we're bulletproof :-)

> Autoset MAVEN_HOME on Win32
> ---------------------------
>
>          Key: MAVEN-1730
>          URL: http://jira.codehaus.org/browse/MAVEN-1730
>      Project: Maven
>         Type: Improvement
>   Components: core
>  Environment: Windows
>     Reporter: Anton Tagunov
>  Attachments: maven.bat.2.diff, maven.bat.3.diff, maven.bat.diff
>
>
> I've had this put into ant.bat, now let's put it into maven.bat Here's how to see my patch usefullness:
> Run on Windows.
> Set JAVA_HOME.
> Add maven/bin added to %PATH%.
> Do not set MAVEN_HOME.
> Type maven -v
> Before my patch: ERROR: MAVEN_HOME not found in your environment.
> After my patch: maven run proceeds, MAVEN_HOME set to maven/bin/..
> P.S. Have got an apache account, atagunov, but not ready to apply other patches, at least right now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MAVEN-1730) Autoset MAVEN_HOME on Win32

Posted by "Anton Tagunov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MAVEN-1730?page=comments#action_53047 ] 

Anton Tagunov commented on MAVEN-1730:
--------------------------------------

C'on, guys!

Just go and apply maven.bat.3.diff!

> Autoset MAVEN_HOME on Win32
> ---------------------------
>
>          Key: MAVEN-1730
>          URL: http://jira.codehaus.org/browse/MAVEN-1730
>      Project: Maven
>         Type: Improvement

>   Components: core
>  Environment: Windows
>     Reporter: Anton Tagunov
>  Attachments: maven.bat.2.diff, maven.bat.3.diff, maven.bat.diff
>
>
> I've had this put into ant.bat, now let's put it into maven.bat Here's how to see my patch usefullness:
> Run on Windows.
> Set JAVA_HOME.
> Add maven/bin added to %PATH%.
> Do not set MAVEN_HOME.
> Type maven -v
> Before my patch: ERROR: MAVEN_HOME not found in your environment.
> After my patch: maven run proceeds, MAVEN_HOME set to maven/bin/..
> P.S. Have got an apache account, atagunov, but not ready to apply other patches, at least right now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MAVEN-1730) Autoset MAVEN_HOME on Win32

Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MAVEN-1730?page=all ]
     
Arnaud Heritier closed MAVEN-1730:
----------------------------------

     Resolution: Fixed
    Fix Version: 1.1-beta-3

Applied. Thx.

> Autoset MAVEN_HOME on Win32
> ---------------------------
>
>          Key: MAVEN-1730
>          URL: http://jira.codehaus.org/browse/MAVEN-1730
>      Project: Maven
>         Type: Improvement

>   Components: core
>  Environment: Windows
>     Reporter: Anton Tagunov
>     Assignee: Arnaud Heritier
>      Fix For: 1.1-beta-3
>  Attachments: maven.bat.2.diff, maven.bat.3.diff, maven.bat.diff
>
>
> I've had this put into ant.bat, now let's put it into maven.bat Here's how to see my patch usefullness:
> Run on Windows.
> Set JAVA_HOME.
> Add maven/bin added to %PATH%.
> Do not set MAVEN_HOME.
> Type maven -v
> Before my patch: ERROR: MAVEN_HOME not found in your environment.
> After my patch: maven run proceeds, MAVEN_HOME set to maven/bin/..
> P.S. Have got an apache account, atagunov, but not ready to apply other patches, at least right now.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org