You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/15 18:38:17 UTC
[GitHub] [tvm] AndrewZhaoLuo opened a new pull request #7860: [WIP] Add support for relay expressions as pad value for static pad
AndrewZhaoLuo opened a new pull request #7860:
URL: https://github.com/apache/tvm/pull/7860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on pull request #7860: Add support for relay expressions as pad value for static pad
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #7860:
URL: https://github.com/apache/tvm/pull/7860#issuecomment-820714648
@mbrookhart @jwfromm please add appropriate reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7860: [Relay] Add support for relay expressions as pad value for static pad
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7860:
URL: https://github.com/apache/tvm/pull/7860#issuecomment-823520212
Thanks @AndrewZhaoLuo @electriclilies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart merged pull request #7860: [Relay] Add support for relay expressions as pad value for static pad
Posted by GitBox <gi...@apache.org>.
mbrookhart merged pull request #7860:
URL: https://github.com/apache/tvm/pull/7860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #7860: Add support for relay expressions as pad value for static pad
Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on a change in pull request #7860:
URL: https://github.com/apache/tvm/pull/7860#discussion_r614406560
##########
File path: src/relay/op/nn/pad.cc
##########
@@ -114,7 +114,7 @@ Array<Array<Layout>> PadInferCorrectLayout(const Attrs& attrs, const Array<Layou
bool PadRel(const Array<Type>& types, int num_inputs, const Attrs& attrs,
const TypeReporter& reporter) {
- ICHECK_EQ(types.size(), 2);
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] electriclilies commented on a change in pull request #7860: Add support for relay expressions as pad value for static pad
Posted by GitBox <gi...@apache.org>.
electriclilies commented on a change in pull request #7860:
URL: https://github.com/apache/tvm/pull/7860#discussion_r614377652
##########
File path: src/relay/op/nn/pad.cc
##########
@@ -114,7 +114,7 @@ Array<Array<Layout>> PadInferCorrectLayout(const Attrs& attrs, const Array<Layou
bool PadRel(const Array<Type>& types, int num_inputs, const Attrs& attrs,
const TypeReporter& reporter) {
- ICHECK_EQ(types.size(), 2);
Review comment:
Could you add a comment saying what is in the types array while you're making these changes? Something like
`// types = [pad_width_type, pad_value_type, ret_type]` (some of the type rels have these annotations and I find them helpful)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org