You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "DJ-Raven (via GitHub)" <gi...@apache.org> on 2024/09/26 10:05:20 UTC
[PR] Remove textArea border in MultiLineComboBoxEditor [netbeans]
DJ-Raven opened a new pull request, #7799:
URL: https://github.com/apache/netbeans/pull/7799
This PR update the UI. by removed textArea border in `MultiLineComboBoxEditor` class
This `MultiLineComboBoxEditor` use in:
- Find in Projects by pressed `Ctrl+F`
- Replace in Projects by pressed `Ctrl+H`
### After changed
Preview with flatlaf light laf
Preview with flatlaf light cupertino (multi line search)
Please review, Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove textArea border in MultiLineComboBoxEditor [netbeans]
Posted by "DJ-Raven (via GitHub)" <gi...@apache.org>.
DJ-Raven commented on PR #7799:
URL: https://github.com/apache/netbeans/pull/7799#issuecomment-2379675600
Thank @mbien @eirikbakke for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove textArea border in MultiLineComboBoxEditor [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7799:
URL: https://github.com/apache/netbeans/pull/7799#issuecomment-2379698085
> I don't think the alignment problems in older LAFs are due to this patch;
yes, this is not what I meant. This dialog is somewhat special since it uses the old grid bag layout which doesn't implement text baseline alignment for neighboring components if i remember correctly. Two combo boxes are also multi line fields with dynamic height - so this is to be expected that it won't look nice on all LAFs. (I remember starring at the dialog a while while doing https://github.com/apache/netbeans/pull/3393)
What i meant was that the GTK laf specifically looks inconsistent everywhere else too. Toolbar icons have the wrong size and every combo box looks different. I set `-J-Djdk.gtk.version=2` for VisualVM to make it somewhat useable (fixes the toolbars at least).
I am wondering if we should filter it out from the LAF list? I guess users could still use the flag to force it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove textArea border in MultiLineComboBoxEditor [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7799:
URL: https://github.com/apache/netbeans/pull/7799#issuecomment-2376723653
awesome, thanks for the fix!
@DJ-Raven could you update the commit author to your full name like in your last PR?
for comparison:
- this PR: https://github.com/apache/netbeans/pull/7799.patch
- last PR: https://github.com/apache/netbeans/pull/7332.patch
```
git commit --amend --author="Author Name <em...@address.com>" --no-edit
```
and simply force push
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove textArea border in MultiLineComboBoxEditor [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke merged PR #7799:
URL: https://github.com/apache/netbeans/pull/7799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove textArea border in MultiLineComboBoxEditor [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #7799:
URL: https://github.com/apache/netbeans/pull/7799#issuecomment-2379655578
Yeah, I don't think the alignment problems in older LAFs are due to this patch; I saw them when trying Nimbus without the patch, for instance. (In any case I don't think much effort needs to be spent on the older LAFs at this point; they just served as a useful "test case" for the patch.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove textArea border in MultiLineComboBoxEditor [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #7799:
URL: https://github.com/apache/netbeans/pull/7799#issuecomment-2379660082
Merged it--thanks again for the patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove textArea border in MultiLineComboBoxEditor [netbeans]
Posted by "DJ-Raven (via GitHub)" <gi...@apache.org>.
DJ-Raven commented on PR #7799:
URL: https://github.com/apache/netbeans/pull/7799#issuecomment-2376750642
@mbien already push
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Remove textArea border in MultiLineComboBoxEditor [netbeans]
Posted by "eirikbakke (via GitHub)" <gi...@apache.org>.
eirikbakke commented on PR #7799:
URL: https://github.com/apache/netbeans/pull/7799#issuecomment-2379994047
> I am wondering if we should filter it out from the LAF list? I guess users could still use the flag to force it.
Perhaps? Or otherwise advertise that we really recommend FlatLAF over the other ones.
The main reason to keep the older LAFs around is that it's useful to have each of the basic Java LAFs available in the list for people who are developing Swing apps and would like to see what each one of them looks like in the context of the full IDE. It's also useful during NetBeans IDE development, to test Swing code changes with different LAFs to make sure the code does not make accidental assumptions about specific LAF implementation details.
> I set -J-Djdk.gtk.version=2 for VisualVM to make it somewhat useable (fixes the toolbars at least).
I think we used to have that setting as default in NetBeans, until https://issues.apache.org/jira/browse/NETBEANS-5862 removed it. Maybe certain issues appeared to have been fixed in the JDK, but others were not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists