You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/04/22 18:10:13 UTC

[GitHub] [fineract] nemux edited a comment on issue #780: FINERACT-897 - Added missing `grouping` keywords from https://github.com/apache/fi…

nemux edited a comment on issue #780:
URL: https://github.com/apache/fineract/pull/780#issuecomment-617941610


   > Thanks! So this is strictly required for MySQL v8? These things have a tendency to creep back in, over time... ;-) Any thoughts about how to prevent that? Would you like to try switching the Travis CI configuration to use MySQL v8?
   
   Yes @vorburger , according to the MySQL reference manual GROUPING became a reserved word in 8.0.1 https://dev.mysql.com/doc/refman/8.0/en/keywords.html
   
   ![imagen](https://user-images.githubusercontent.com/3644786/80017492-4b37ce80-849a-11ea-873d-cd69385657c2.png)
   
   Let me make a test in a previous MySQL version using GROUPING quoted, but according to the documentation should be allowed quoted or not because in previous versions is not a reserved word.
   
   ![imagen](https://user-images.githubusercontent.com/3644786/80017403-2ba0a600-849a-11ea-9cc7-6274a065cb2e.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org