You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/25 02:26:49 UTC

[GitHub] [flink] wuchong commented on a change in pull request #11425: [FLINK-16125][kafka] Remove unnecessary zookeeper.connect property validation

wuchong commented on a change in pull request #11425: [FLINK-16125][kafka] Remove unnecessary zookeeper.connect property validation
URL: https://github.com/apache/flink/pull/11425#discussion_r397574019
 
 

 ##########
 File path: flink-end-to-end-tests/flink-confluent-schema-registry/src/main/java/org/apache/flink/schema/registry/test/TestAvroConsumerConfluent.java
 ##########
 @@ -49,14 +49,12 @@ public static void main(String[] args) throws Exception {
 			System.out.println("Missing parameters!\n" +
 				"Usage: Kafka --input-topic <topic> --output-string-topic <topic> --output-avro-topic <topic> " +
 				"--bootstrap.servers <kafka brokers> " +
-				"--zookeeper.connect <zk quorum> " +
 
 Review comment:
   Hi @becketqin , could you help to review this? 
   This PR also remove `zookeeper.connect` properties for non-table-modules. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services