[GitHub] [calcite] julianhyde commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type

[GitBox <gi...@apache.org>]

julianhyde commented on a change in pull request #1250: [CALCITE-3108] Babel parser should parse the PostgreSQL TEXT type
URL: https://github.com/apache/calcite/pull/1250#discussion_r290953980
 
 

 ##########
 File path: babel/src/main/codegen/config.fmpp
 ##########
 @@ -833,6 +835,7 @@ data: {
       # Return type of method implementation should be "SqlIdentifier".
       # Example: SqlParseTimeStampZ().
       dataTypeParserMethods: [
+         "PostgreSQLTypes"
 
 Review comment:
   A lot of databases support user-defined types. In Postgres I can say `(1 + 2) :: Foo` if `Foo` is a user-defined type.
   
   Why not treat `TEXT` as if it is a user-defined type? The parser will just see an identifier.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services