You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/03/23 03:41:19 UTC

[GitHub] [james-project] Arsnael commented on a change in pull request #926: JAMES-3715 Small round of Netty4 polishing

Arsnael commented on a change in pull request #926:
URL: https://github.com/apache/james-project/pull/926#discussion_r832819000



##########
File path: mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/GhostMailbox.java
##########
@@ -35,6 +35,14 @@
     public static final String TYPE = "type";
     public static final String MAILBOX_ID = "mailboxId";
 
+    public static boolean isDebugEnabled() {
+        return LOGGER.isDebugEnabled();
+    }
+
+    public static boolean isInfoEnabled() {
+        return LOGGER.isDebugEnabled();

Review comment:
       You return here if debug is enabled, nothing to do with info...
   
   I don't think the method `isInfoEnabled` would be used anyway, and it's not in your code for now. We can remove it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org