You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/04/03 12:24:31 UTC

Review Request 58146: Added infrastructure for unit tests in the new python-based CLI.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58146/
-----------------------------------------------------------

Review request for mesos and Kevin Klues.


Bugs: MESOS-6032
    https://issues.apache.org/jira/browse/MESOS-6032


Repository: mesos


Description
-------

This is the base to develop unit tests for the Mesos CLI.


Diffs
-----

  src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af 
  src/cli_new/bin/mesos-cli-tests PRE-CREATION 
  src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf 
  src/cli_new/tests/main.py PRE-CREATION 


Diff: https://reviews.apache.org/r/58146/diff/1/


Testing
-------

$ cd src/cli_new
$ ./bootstrap
$ source activate

(mesos-cli) $ mesos-cli-tests


Thanks,

Armand Grillet


Re: Review Request 58146: Added infrastructure for unit tests in the new python-based CLI.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58146/#review170871
-----------------------------------------------------------



Patch looks great!

Reviews applied: [58146]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 3, 2017, 12:24 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58146/
> -----------------------------------------------------------
> 
> (Updated April 3, 2017, 12:24 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-6032
>     https://issues.apache.org/jira/browse/MESOS-6032
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is the base to develop unit tests for the Mesos CLI.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af 
>   src/cli_new/bin/mesos-cli-tests PRE-CREATION 
>   src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf 
>   src/cli_new/tests/main.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58146/diff/1/
> 
> 
> Testing
> -------
> 
> $ cd src/cli_new
> $ ./bootstrap
> $ source activate
> 
> (mesos-cli) $ mesos-cli-tests
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>