You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Igor Galić (JIRA)" <ji...@apache.org> on 2011/09/18 04:53:08 UTC
[jira] [Created] (TS-960) Make "error documents" templatable to the
administrator
Make "error documents" templatable to the administrator
-------------------------------------------------------
Key: TS-960
URL: https://issues.apache.org/jira/browse/TS-960
Project: Traffic Server
Issue Type: Improvement
Affects Versions: 3.1.1
Reporter: Igor Galić
I believe it would be enormously usable to the Administrator to have templatable (editable) error documents (like httpd does)
That means to remove the HTML code from proxy/http/HttpMessageBody.cc and put it in a template
replace things title with @@TITLE@@ or similar -- maybe even WARN the user that they have to occur in exactly that order to work, so as to make parsing as simple as possible.?
In any case this template should be cached, and only read once upon startup. We have a cache, after all, we should use it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Created] (TS-960) Make "error documents" templatable to the administrator
Posted by Leif Hedstrom <zw...@apache.org>.
Pretty sure we have this already.
-- leif
On Sep 17, 2011, at 8:53 PM, Igor Galić (JIRA) <ji...@apache.org> wrote:
> Make "error documents" templatable to the administrator
> -------------------------------------------------------
>
> Key: TS-960
> URL: https://issues.apache.org/jira/browse/TS-960
> Project: Traffic Server
> Issue Type: Improvement
> Affects Versions: 3.1.1
> Reporter: Igor Galić
>
>
> I believe it would be enormously usable to the Administrator to have templatable (editable) error documents (like httpd does)
>
> That means to remove the HTML code from proxy/http/HttpMessageBody.cc and put it in a template
> replace things title with @@TITLE@@ or similar -- maybe even WARN the user that they have to occur in exactly that order to work, so as to make parsing as simple as possible.?
>
> In any case this template should be cached, and only read once upon startup. We have a cache, after all, we should use it.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Resolved] (TS-960) Make "error documents" templatable to
the administrator
Posted by "Igor Galić (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Galić resolved TS-960.
---------------------------
Resolution: Fixed
Fix Version/s: (was: sometime)
3.3.1
This appears to have been solved by TS-1549
Of course what's still not implemented is the caching of the {{body_factory}} - but, yeah, baby steps.
> Make "error documents" templatable to the administrator
> -------------------------------------------------------
>
> Key: TS-960
> URL: https://issues.apache.org/jira/browse/TS-960
> Project: Traffic Server
> Issue Type: Improvement
> Affects Versions: 3.1.1
> Reporter: Igor Galić
> Assignee: Igor Galić
> Fix For: 3.3.1
>
>
> I believe it would be enormously usable to the Administrator to have templatable (editable) error documents (like httpd does)
> That means to remove the HTML code from proxy/http/HttpMessageBody.cc and put it in a template
> replace things title with @@TITLE@@ or similar -- maybe even WARN the user that they have to occur in exactly that order to work, so as to make parsing as simple as possible.?
> In any case this template should be cached, and only read once upon startup. We have a cache, after all, we should use it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-960) Make "error documents" templatable to the
administrator
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-960:
-----------------------------
Fix Version/s: sometime
> Make "error documents" templatable to the administrator
> -------------------------------------------------------
>
> Key: TS-960
> URL: https://issues.apache.org/jira/browse/TS-960
> Project: Traffic Server
> Issue Type: Improvement
> Affects Versions: 3.1.1
> Reporter: Igor Galić
> Fix For: sometime
>
>
> I believe it would be enormously usable to the Administrator to have templatable (editable) error documents (like httpd does)
> That means to remove the HTML code from proxy/http/HttpMessageBody.cc and put it in a template
> replace things title with @@TITLE@@ or similar -- maybe even WARN the user that they have to occur in exactly that order to work, so as to make parsing as simple as possible.?
> In any case this template should be cached, and only read once upon startup. We have a cache, after all, we should use it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-960) Make "error documents" templatable to
the administrator
Posted by "James Peach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Peach reassigned TS-960:
------------------------------
Assignee: Igor Galić
Igor, is there anything more you want to do here?
> Make "error documents" templatable to the administrator
> -------------------------------------------------------
>
> Key: TS-960
> URL: https://issues.apache.org/jira/browse/TS-960
> Project: Traffic Server
> Issue Type: Improvement
> Affects Versions: 3.1.1
> Reporter: Igor Galić
> Assignee: Igor Galić
> Fix For: sometime
>
>
> I believe it would be enormously usable to the Administrator to have templatable (editable) error documents (like httpd does)
> That means to remove the HTML code from proxy/http/HttpMessageBody.cc and put it in a template
> replace things title with @@TITLE@@ or similar -- maybe even WARN the user that they have to occur in exactly that order to work, so as to make parsing as simple as possible.?
> In any case this template should be cached, and only read once upon startup. We have a cache, after all, we should use it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-960) Make "error documents" templatable to
the administrator
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107584#comment-13107584 ]
Leif Hedstrom commented on TS-960:
----------------------------------
I think that's what proxy.config.body_factory.enable_customizations is for, no ? The hardcoded stuff are "defaults", which you can override. Not sure why they are hardcoded, presumably for performance, but that seems like a small win honestly (but, not sure).
> Make "error documents" templatable to the administrator
> -------------------------------------------------------
>
> Key: TS-960
> URL: https://issues.apache.org/jira/browse/TS-960
> Project: Traffic Server
> Issue Type: Improvement
> Affects Versions: 3.1.1
> Reporter: Igor Galić
>
> I believe it would be enormously usable to the Administrator to have templatable (editable) error documents (like httpd does)
> That means to remove the HTML code from proxy/http/HttpMessageBody.cc and put it in a template
> replace things title with @@TITLE@@ or similar -- maybe even WARN the user that they have to occur in exactly that order to work, so as to make parsing as simple as possible.?
> In any case this template should be cached, and only read once upon startup. We have a cache, after all, we should use it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira