[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6992: WS2812 LED driver using ESP32's RMT peripheral

[GitBox <gi...@apache.org>]

hartmannathan commented on code in PR #6992:
URL: https://github.com/apache/incubator-nuttx/pull/6992#discussion_r961960719


##########
boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c:
##########
@@ -162,91 +166,91 @@ int esp32_bringup(void)
 #ifdef CONFIG_ESP32_AES_ACCELERATOR
   ret = esp32_aes_init();
   if (ret < 0)
-    {
-      syslog(LOG_ERR,
-             "ERROR: Failed to initialize AES: %d\n", ret);
-    }
+  {

Review Comment:
   To check coding style, there is the program under tools/nxstyle.c. Just compile with:
   
   ```
   cd tools
   gcc nxstyle.c -o nxstyle
   cd ..
   ```
   
   and run it on the file in question, e.g.,
   
   ```
   $ tools/nxstyle boards/xtensa/esp32/esp32-devkitc/src/esp32_bringup.c
   ```
   
   It will print nothing if all is well or tell you which areas fail the check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org