You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "David Hull (JIRA)" <ji...@apache.org> on 2019/02/15 00:14:00 UTC

[jira] [Commented] (THRIFT-4056) Skip() should throw TProtocolException.INVALID_DATA on unknown data types

    [ https://issues.apache.org/jira/browse/THRIFT-4056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768822#comment-16768822 ] 

David Hull commented on THRIFT-4056:
------------------------------------

The Erlang library's {{skip}} function has special handling for structs and the containers (set, map, list) but then just calls the normal {{read}} function to read the remaining types. I'm fairly certain that the call will throw a function_clause error if an unknown data type is found. It would be nice if there was a test case; I did not see one in the [pull request|https://github.com/apache/thrift/pull/1742].

> Skip() should throw TProtocolException.INVALID_DATA on unknown data types
> -------------------------------------------------------------------------
>
>                 Key: THRIFT-4056
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4056
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: Erlang - Library
>            Reporter: Jens Geyer
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)