You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/12/01 08:10:23 UTC

[GitHub] [cordova-android] erisu opened a new pull request #1138: feat(allow-list): integrate and refactor core plugin

erisu opened a new pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138


   ### Motivation, Context & Description
   
   Integrate the Allow List core plugin to platform.
   
   ### Testing
   
   - `npm t`
   - `cordova create`
   - `cordova platform add`
   - `cordova build android`
   
   Run in emulator though Android Studio.
   
   * Must remove the original plugin that is configured with new projects.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] dalybouba edited a comment on pull request #1138: feat(allow-list)!: integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
dalybouba edited a comment on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-1049783411


   please I'm tired with the build anyone can help me please with those issue 👍 
   
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\BackgroundActionButtonHandler.java:9: error: cannot find symbol
   [cordova] import android.support.v4.app.RemoteInput;
   [cordova]                              ^
   [cordova]   symbol:   class RemoteInput
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:26: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:27: error: package android.support.v4.app.NotificationCompat does not
    exist
   [cordova] import android.support.v4.app.NotificationCompat.WearableExtender;
   [cordova]                                                 ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:28: error: cannot find symbol
   [cordova] import android.support.v4.app.RemoteInput;
   [cordova]                              ^
   [cordova]   symbol:   class RemoteInput
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:528: error: package NotificationCompat does not exist
   [cordova]   private void createActions(Bundle extras, NotificationCompat.Builder mBuilder, Resources resources,
   [cordova]                                                               ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:612: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationCount(Context context, Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                       ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:620: error: package NotificationCompat does not exist
   [cordova]   private void setVisibility(Context context, Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:636: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationVibration(Bundle extras, Boolean vibrateOption, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                                 ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:655: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationOngoing(Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                        ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:660: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationMessage(int notId, Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                   ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:731: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationSound(Context context, Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                       ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:748: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationLedColor(Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:768: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationPriority(Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:813: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.Builder mBuilder) {
   [cordova]                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:863: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.Builder mBuilder, String localIcon) {
   [cordova]                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:880: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationIconColor(String color, NotificationCompat.Builder mBuilder, String localIconColor) {
   [cordova]                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushHandlerActivity.java:10: error: cannot find symbol
   [cordova] import android.support.v4.app.RemoteInput;
   [cordova]                              ^
   [cordova]   symbol:   class RemoteInput
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:15: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:16: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationManagerCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationManagerCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\evgenii\jsevaluator\JsEvaluator.java:4: error: package android.support.annotation does not exist
   [cordova] import android.support.annotation.VisibleForTesting;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:17: error: package android.support.v4.content does not
    exist
   [cordova] import android.support.v4.content.ContextCompat;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:18: error: package android.support.v4.content does not
    exist
   [cordova] import android.support.v4.content.LocalBroadcastManager;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\Config.java:15: error: package android.support.annotation does not exist
   [cordova] import android.support.annotation.Nullable;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\BackgroundLocation.java:10: error: package android.support.v4.util does not exist
   [cordova] import android.support.v4.util.TimeUtils;
   [cordova]                               ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:4: error: package android.support.annotation does not exist
   [cordova] import android.support.annotation.NonNull;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:5: error: package android.support.annotation does not exist
   [cordova] import android.support.annotation.Nullable;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:32: error: package android.support.annotation does not
    exist
   [cordova] import android.support.annotation.Nullable;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:33: error: package android.support.v4.content does not
    exist
   [cordova] import android.support.v4.content.LocalBroadcastManager;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceIntentBuilder.java:24: error: package android.support.annotation
    does not exist
   [cordova] import android.support.annotation.IntDef;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceIntentBuilder.java:31: error: cannot find symbol
   [cordova] @IntDef({
   [cordova]  ^
   [cordova]   symbol: class IntDef
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:12: error: package android.support.annotation does not exi
   st
   [cordova] import android.support.annotation.RequiresApi;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:13: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:14: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:15: error: package android.support.v4.content does not exist
   [cordova] import android.support.v4.content.LocalBroadcastManager;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\evgenii\jsevaluator\JsEvaluator.java:118: error: cannot find symbol
   [cordova]       @VisibleForTesting
   [cordova]        ^
   [cordova]   symbol:   class VisibleForTesting
   [cordova]   location: class JsEvaluator
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\evgenii\jsevaluator\JsEvaluator.java:123: error: cannot find symbol
   [cordova]       @VisibleForTesting
   [cordova]        ^
   [cordova]   symbol:   class VisibleForTesting
   [cordova]   location: class JsEvaluator
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\evgenii\jsevaluator\JsEvaluator.java:128: error: cannot find symbol
   [cordova]       @VisibleForTesting
   [cordova]        ^
   [cordova]   symbol:   class VisibleForTesting
   [cordova]   location: class JsEvaluator
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\Config.java:355: error: cannot find symbol
   [cordova]     @Nullable
   [cordova]      ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: class Config
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\Config.java:360: error: cannot find symbol
   [cordova]     public void setNotificationsEnabled(@Nullable Boolean notificationsEnabled) {
   [cordova]                                          ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: class Config
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:20: error: cannot find symbol
   [cordova]     BackgroundLocation transformLocationBeforeCommit(@NonNull Context context, @NonNull BackgroundLocation location);
   [cordova]                                                       ^
   [cordova]   symbol:   class NonNull
   [cordova]   location: interface LocationTransform
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:20: error: cannot find symbol
   [cordova]     BackgroundLocation transformLocationBeforeCommit(@NonNull Context context, @NonNull BackgroundLocation location);
   [cordova]                                                                                 ^
   [cordova]   symbol:   class NonNull
   [cordova]   location: interface LocationTransform
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:19: error: cannot find symbol
   [cordova]     @Nullable
   [cordova]      ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: interface LocationTransform
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:739: error: cannot find symbol
   [cordova]     public static void setLocationTransform(@Nullable LocationTransform transform) {
   [cordova]                                              ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: class LocationServiceImpl
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:743: error: cannot find symbol
   [cordova]     public static @Nullable LocationTransform getLocationTransform() {
   [cordova]                    ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: class LocationServiceImpl
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:119: error: cannot find symbol
   [cordova]     @RequiresApi(api = Build.VERSION_CODES.O)
   [cordova]      ^
   [cordova]   symbol:   class RequiresApi
   [cordova]   location: class NotificationHelper
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:126: error: cannot find symbol
   [cordova]     @RequiresApi(api = Build.VERSION_CODES.O)
   [cordova]      ^
   [cordova]   symbol:   class RequiresApi
   [cordova]   location: class NotificationHelper
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:134: error: cannot find symbol
   [cordova]     @RequiresApi(api = Build.VERSION_CODES.O)
   [cordova]      ^
   [cordova]   symbol:   class RequiresApi
   [cordova]   location: class NotificationHelper
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\BackgroundActionButtonHandler.java:31: error: cannot find symbol
   [cordova]             Bundle remoteInput = RemoteInput.getResultsFromIntent(intent);
   [cordova]                                  ^
   [cordova]   symbol:   variable RemoteInput
   [cordova]   location: class BackgroundActionButtonHandler
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:395: error: package NotificationCompat does not exist
   [cordova]     NotificationCompat.Builder mBuilder = null;
   [cordova]                       ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:402: error: package NotificationCompat does not exist
   [cordova]         mBuilder = new NotificationCompat.Builder(context, channelID);
   [cordova]                                          ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:412: error: package NotificationCompat does not exist
   [cordova]         mBuilder = new NotificationCompat.Builder(context, channelID);
   [cordova]                                          ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:416: error: package NotificationCompat does not exist
   [cordova]       mBuilder = new NotificationCompat.Builder(context);
   [cordova]                                        ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:535: error: package NotificationCompat does not exist
   [cordova]         ArrayList<NotificationCompat.Action> wActions = new ArrayList<NotificationCompat.Action>();
   [cordova]                                     ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:535: error: package NotificationCompat does not exist
   [cordova]         ArrayList<NotificationCompat.Action> wActions = new ArrayList<NotificationCompat.Action>();
   [cordova]                                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:581: error: package NotificationCompat.Action does not exist
   [cordova]           NotificationCompat.Action.Builder actionBuilder = new NotificationCompat.Action.Builder(
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:581: error: package NotificationCompat.Action does not exist
   [cordova]           NotificationCompat.Action.Builder actionBuilder = new NotificationCompat.Action.Builder(
   [cordova]                                                                                          ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:584: error: cannot find symbol
   [cordova]           RemoteInput remoteInput = null;
   [cordova]           ^
   [cordova]   symbol:   class RemoteInput
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:588: error: package RemoteInput does not exist
   [cordova]             remoteInput = new RemoteInput.Builder(INLINE_REPLY).setLabel(replyLabel).build();
   [cordova]                                          ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:592: error: package NotificationCompat does not exist
   [cordova]           NotificationCompat.Action wAction = actionBuilder.build();
   [cordova]                             ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:604: error: cannot find symbol
   [cordova]         mBuilder.extend(new WearableExtender().addActions(wActions));
   [cordova]                             ^
   [cordova]   symbol:   class WearableExtender
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:625: error: cannot find symbol
   [cordova]         if (visibility >= NotificationCompat.VISIBILITY_SECRET && visibility <= NotificationCompat.VISIBILITY_PUBLIC) {
   [cordova]                           ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:625: error: cannot find symbol
   [cordova]         if (visibility >= NotificationCompat.VISIBILITY_SECRET && visibility <= NotificationCompat.VISIBILITY_PUBLIC) {
   [cordova]                                                                                 ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:677: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.InboxStyle notificationInbox = new NotificationCompat.InboxStyle()
   [cordova]                           ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:677: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.InboxStyle notificationInbox = new NotificationCompat.InboxStyle()
   [cordova]                                                                                 ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:686: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.BigTextStyle bigText = new NotificationCompat.BigTextStyle();
   [cordova]                           ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:686: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.BigTextStyle bigText = new NotificationCompat.BigTextStyle();
   [cordova]                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:696: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.BigPictureStyle bigPicture = new NotificationCompat.BigPictureStyle();
   [cordova]                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:696: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.BigPictureStyle bigPicture = new NotificationCompat.BigPictureStyle();
   [cordova]                                                                             ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:708: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.BigTextStyle bigText = new NotificationCompat.BigTextStyle();
   [cordova]                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:708: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.BigTextStyle bigText = new NotificationCompat.BigTextStyle();
   [cordova]                                                                       ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:773: error: cannot find symbol
   [cordova]         if (priority >= NotificationCompat.PRIORITY_MIN && priority <= NotificationCompat.PRIORITY_MAX) {
   [cordova]                         ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:773: error: cannot find symbol
   [cordova]         if (priority >= NotificationCompat.PRIORITY_MIN && priority <= NotificationCompat.PRIORITY_MAX) {
   [cordova]                                                                        ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushHandlerActivity.java:87: error: cannot find symbol
   [cordova]             remoteInput = RemoteInput.getResultsFromIntent(intent);
   [cordova]                           ^
   [cordova]   symbol:   variable RemoteInput
   [cordova]   location: class PushHandlerActivity
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:105: error: cannot find symbol
   [cordova]       int visibility = channel.optInt(VISIBILITY, NotificationCompat.VISIBILITY_PUBLIC);
   [cordova]                                                   ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class PushPlugin
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:322: error: cannot find symbol
   [cordova]                 "has permission: " + NotificationManagerCompat.from(getApplicationContext()).areNotificationsEnabled());
   [cordova]                                      ^
   [cordova]   symbol: variable NotificationManagerCompat
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:323: error: cannot find symbol
   [cordova]             jo.put("isEnabled", NotificationManagerCompat.from(getApplicationContext()).areNotificationsEnabled());
   [cordova]                                 ^
   [cordova]   symbol: variable NotificationManagerCompat
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:199: error: cannot find symbol
   [cordova]         LocalBroadcastManager.getInstance(getContext()).registerReceiver(serviceBroadcastReceiver, new IntentFilter(LocationServiceImpl.ACTION_BROADCAST));
   [cordova]         ^
   [cordova]   symbol:   variable LocalBroadcastManager
   [cordova]   location: class BackgroundGeolocationFacade
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:208: error: cannot find symbol
   [cordova]             LocalBroadcastManager.getInstance(context).unregisterReceiver(serviceBroadcastReceiver);
   [cordova]             ^
   [cordova]   symbol:   variable LocalBroadcastManager
   [cordova]   location: class BackgroundGeolocationFacade
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:489: error: cannot find symbol
   [cordova]             if (ContextCompat.checkSelfPermission(context, perm) != PackageManager.PERMISSION_GRANTED) {
   [cordova]                 ^
   [cordova]   symbol:   variable ContextCompat
   [cordova]   location: class BackgroundGeolocationFacade
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\BackgroundLocation.java:824: error: cannot find symbol
   [cordova]             TimeUtils.formatDuration(elapsedRealtimeNanos / 1000000L, s);
   [cordova]             ^
   [cordova]   symbol:   variable TimeUtils
   [cordova]   location: class BackgroundLocation
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\BackgroundActivity.java:20: error: cannot access zzbfm
   [cordova]         confidence = activity.getConfidence();
   [cordova]                              ^
   [cordova]   class file for com.google.android.gms.internal.zzbfm not found
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:628: error: cannot find symbol
   [cordova]         LocalBroadcastManager.getInstance(getApplicationContext()).sendBroadcast(intent);
   [cordova]         ^
   [cordova]   symbol:   variable LocalBroadcastManager
   [cordova]   location: class LocationServiceImpl
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:55: error: package NotificationCompat does not exist
   [cordova]             NotificationCompat.Builder builder = new NotificationCompat.Builder(mContext, NotificationHelper.SERVICE_CHANNEL_ID);
   [cordova]                               ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:55: error: package NotificationCompat does not exist
   [cordova]             NotificationCompat.Builder builder = new NotificationCompat.Builder(mContext, NotificationHelper.SERVICE_CHANNEL_ID);
   [cordova]                                                                        ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:144: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.Builder builder = null;
   [cordova]                           ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:147: error: package NotificationCompat does not exist
   [cordova]             builder = new NotificationCompat.Builder(getContext(), NotificationHelper.SYNC_CHANNEL_ID);
   [cordova]                                             ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:218: error: package NotificationCompat does not exist
   [cordova]             NotificationCompat.Builder builder = new NotificationCompat.Builder(getContext(), NotificationHelper.SYNC_CHANNEL_ID);
   [cordova]                               ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:218: error: package NotificationCompat does not exist
   [cordova]             NotificationCompat.Builder builder = new NotificationCompat.Builder(getContext(), NotificationHelper.SYNC_CHANNEL_ID);
   [cordova]                                                                        ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:231: error: cannot find symbol
   [cordova]         LocalBroadcastManager.getInstance(getContext().getApplicationContext()).sendBroadcast(intent);
   [cordova]         ^
   [cordova]   symbol:   variable LocalBroadcastManager
   [cordova]   location: class SyncAdapter
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io edited a comment on pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-737032816


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=h1) Report
   > Merging [#1138](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=desc) (4fc48ff) into [master](https://codecov.io/gh/apache/cordova-android/commit/97e2d15634f3c7a37e468cdafcb697257340570c?el=desc) (97e2d15) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1138/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1138      +/-   ##
   ==========================================
   - Coverage   71.19%   71.13%   -0.06%     
   ==========================================
     Files          21       21              
     Lines        1739     1739              
   ==========================================
   - Hits         1238     1237       -1     
   - Misses        501      502       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1138/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.75% <0.00%> (-0.49%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=footer). Last update [97e2d15...4fc48ff](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu commented on a change in pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#discussion_r533933504



##########
File path: framework/src/org/apache/cordova/AllowListPlugin.java
##########
@@ -0,0 +1,162 @@
+/*
+       Licensed to the Apache Software Foundation (ASF) under one
+       or more contributor license agreements.  See the NOTICE file
+       distributed with this work for additional information
+       regarding copyright ownership.  The ASF licenses this file
+       to you under the Apache License, Version 2.0 (the
+       "License"); you may not use this file except in compliance
+       with the License.  You may obtain a copy of the License at
+
+         http://www.apache.org/licenses/LICENSE-2.0
+
+       Unless required by applicable law or agreed to in writing,
+       software distributed under the License is distributed on an
+       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+       KIND, either express or implied.  See the License for the
+       specific language governing permissions and limitations
+       under the License.
+*/
+
+package org.apache.cordova;
+
+import org.apache.cordova.CordovaPlugin;
+import org.apache.cordova.ConfigXmlParser;
+import org.apache.cordova.LOG;
+import org.apache.cordova.AllowList;
+import org.xmlpull.v1.XmlPullParser;
+
+import android.content.Context;
+
+public class AllowListPlugin extends CordovaPlugin {
+    public static final String PLUGIN_NAME = "CordovaAllowListPlugin";
+    protected static final String LOG_TAG = "CordovaAllowListPlugin";
+
+    private AllowList allowedNavigations;
+    private AllowList allowedIntents;
+    private AllowList allowedRequests;
+
+    // Used when instantiated via reflection by PluginManager
+    public AllowListPlugin() { }
+
+    // These can be used by embedders to allow Java-configuration of an allow list.
+    public AllowListPlugin(Context context) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(context);
+    }
+
+    public AllowListPlugin(XmlPullParser xmlParser) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(xmlParser);
+    }
+
+    public AllowListPlugin(AllowList allowedNavigations, AllowList allowedIntents, AllowList allowedRequests) {
+        if (allowedRequests == null) {
+            allowedRequests = new AllowList();
+            allowedRequests.addAllowListEntry("file:///*", false);
+            allowedRequests.addAllowListEntry("data:*", false);
+        }
+
+        this.allowedNavigations = allowedNavigations;
+        this.allowedIntents = allowedIntents;
+        this.allowedRequests = allowedRequests;
+    }
+
+    @Override
+    public void pluginInitialize() {
+        if (this.allowedNavigations == null) {
+            this.allowedNavigations = new AllowList();
+            this.allowedIntents = new AllowList();
+            this.allowedRequests = new AllowList();
+
+            new CustomConfigXmlParser().parse(webView.getContext());
+        }
+    }
+
+    private class CustomConfigXmlParser extends ConfigXmlParser {
+        @Override
+        public void handleStartTag(XmlPullParser xml) {
+            String strNode = xml.getName();
+            if (strNode.equals("content")) {
+                String startPage = xml.getAttributeValue(null, "src");
+                allowedNavigations.addAllowListEntry(startPage, false);
+            } else if (strNode.equals("allow-navigation")) {
+                String origin = xml.getAttributeValue(null, "href");
+                if ("*".equals(origin)) {
+                    allowedNavigations.addAllowListEntry("http://*/*", false);
+                    allowedNavigations.addAllowListEntry("https://*/*", false);
+                    allowedNavigations.addAllowListEntry("data:*", false);
+                } else {
+                    allowedNavigations.addAllowListEntry(origin, false);
+                }
+            } else if (strNode.equals("allow-intent")) {
+                String origin = xml.getAttributeValue(null, "href");
+                allowedIntents.addAllowListEntry(origin, false);
+            } else if (strNode.equals("access")) {
+                String origin = xml.getAttributeValue(null, "origin");
+                String subdomains = xml.getAttributeValue(null, "subdomains");
+                boolean external = (xml.getAttributeValue(null, "launch-external") != null);
+                if (origin != null) {
+                    if (external) {
+                        LOG.w(LOG_TAG, "Found <access launch-external> within config.xml. Please use <allow-intent> instead.");

Review comment:
       @dpogue The launch-external has been removed: https://github.com/apache/cordova-android/pull/1138/commits/4fc48ff5093d0d8b5defc9fa9f58a72dc192d582?diff=split&w=1
   
   Also moved `String subdomains` in the else statement where it is used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io edited a comment on pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-737032816


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=h1) Report
   > Merging [#1138](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=desc) (4fc48ff) into [master](https://codecov.io/gh/apache/cordova-android/commit/97e2d15634f3c7a37e468cdafcb697257340570c?el=desc) (97e2d15) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1138/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1138   +/-   ##
   =======================================
     Coverage   71.19%   71.19%           
   =======================================
     Files          21       21           
     Lines        1739     1739           
   =======================================
     Hits         1238     1238           
     Misses        501      501           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=footer). Last update [97e2d15...4fc48ff](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer removed a comment on pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer removed a comment on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-863568380


   @erisu , @NiklasMerz I did merge the master in this branche and opened a new PR ( https://github.com/apache/cordova-android/pull/1244 ) for this. 
   Feel free to merge it, remove it, review it if you like.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu commented on a change in pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#discussion_r533924614



##########
File path: framework/src/org/apache/cordova/AllowListPlugin.java
##########
@@ -0,0 +1,162 @@
+/*
+       Licensed to the Apache Software Foundation (ASF) under one
+       or more contributor license agreements.  See the NOTICE file
+       distributed with this work for additional information
+       regarding copyright ownership.  The ASF licenses this file
+       to you under the Apache License, Version 2.0 (the
+       "License"); you may not use this file except in compliance
+       with the License.  You may obtain a copy of the License at
+
+         http://www.apache.org/licenses/LICENSE-2.0
+
+       Unless required by applicable law or agreed to in writing,
+       software distributed under the License is distributed on an
+       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+       KIND, either express or implied.  See the License for the
+       specific language governing permissions and limitations
+       under the License.
+*/
+
+package org.apache.cordova;
+
+import org.apache.cordova.CordovaPlugin;
+import org.apache.cordova.ConfigXmlParser;
+import org.apache.cordova.LOG;
+import org.apache.cordova.AllowList;
+import org.xmlpull.v1.XmlPullParser;
+
+import android.content.Context;
+
+public class AllowListPlugin extends CordovaPlugin {
+    public static final String PLUGIN_NAME = "CordovaAllowListPlugin";
+    protected static final String LOG_TAG = "CordovaAllowListPlugin";
+
+    private AllowList allowedNavigations;
+    private AllowList allowedIntents;
+    private AllowList allowedRequests;
+
+    // Used when instantiated via reflection by PluginManager
+    public AllowListPlugin() { }
+
+    // These can be used by embedders to allow Java-configuration of an allow list.
+    public AllowListPlugin(Context context) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(context);
+    }
+
+    public AllowListPlugin(XmlPullParser xmlParser) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(xmlParser);
+    }
+
+    public AllowListPlugin(AllowList allowedNavigations, AllowList allowedIntents, AllowList allowedRequests) {
+        if (allowedRequests == null) {
+            allowedRequests = new AllowList();
+            allowedRequests.addAllowListEntry("file:///*", false);
+            allowedRequests.addAllowListEntry("data:*", false);
+        }
+
+        this.allowedNavigations = allowedNavigations;
+        this.allowedIntents = allowedIntents;
+        this.allowedRequests = allowedRequests;
+    }
+
+    @Override
+    public void pluginInitialize() {
+        if (this.allowedNavigations == null) {
+            this.allowedNavigations = new AllowList();
+            this.allowedIntents = new AllowList();
+            this.allowedRequests = new AllowList();
+
+            new CustomConfigXmlParser().parse(webView.getContext());
+        }
+    }
+
+    private class CustomConfigXmlParser extends ConfigXmlParser {
+        @Override
+        public void handleStartTag(XmlPullParser xml) {
+            String strNode = xml.getName();
+            if (strNode.equals("content")) {
+                String startPage = xml.getAttributeValue(null, "src");
+                allowedNavigations.addAllowListEntry(startPage, false);
+            } else if (strNode.equals("allow-navigation")) {
+                String origin = xml.getAttributeValue(null, "href");
+                if ("*".equals(origin)) {
+                    allowedNavigations.addAllowListEntry("http://*/*", false);
+                    allowedNavigations.addAllowListEntry("https://*/*", false);
+                    allowedNavigations.addAllowListEntry("data:*", false);
+                } else {
+                    allowedNavigations.addAllowListEntry(origin, false);
+                }
+            } else if (strNode.equals("allow-intent")) {
+                String origin = xml.getAttributeValue(null, "href");
+                allowedIntents.addAllowListEntry(origin, false);
+            } else if (strNode.equals("access")) {
+                String origin = xml.getAttributeValue(null, "origin");
+                String subdomains = xml.getAttributeValue(null, "subdomains");
+                boolean external = (xml.getAttributeValue(null, "launch-external") != null);
+                if (origin != null) {
+                    if (external) {
+                        LOG.w(LOG_TAG, "Found <access launch-external> within config.xml. Please use <allow-intent> instead.");

Review comment:
       Yes, we can remove this now too... I didn't carefully read to notice that this deprecated code existed. I will go ahead and fix this.

##########
File path: framework/src/org/apache/cordova/AllowListPlugin.java
##########
@@ -0,0 +1,162 @@
+/*
+       Licensed to the Apache Software Foundation (ASF) under one
+       or more contributor license agreements.  See the NOTICE file
+       distributed with this work for additional information
+       regarding copyright ownership.  The ASF licenses this file
+       to you under the Apache License, Version 2.0 (the
+       "License"); you may not use this file except in compliance
+       with the License.  You may obtain a copy of the License at
+
+         http://www.apache.org/licenses/LICENSE-2.0
+
+       Unless required by applicable law or agreed to in writing,
+       software distributed under the License is distributed on an
+       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+       KIND, either express or implied.  See the License for the
+       specific language governing permissions and limitations
+       under the License.
+*/
+
+package org.apache.cordova;
+
+import org.apache.cordova.CordovaPlugin;
+import org.apache.cordova.ConfigXmlParser;
+import org.apache.cordova.LOG;
+import org.apache.cordova.AllowList;
+import org.xmlpull.v1.XmlPullParser;
+
+import android.content.Context;
+
+public class AllowListPlugin extends CordovaPlugin {
+    public static final String PLUGIN_NAME = "CordovaAllowListPlugin";
+    protected static final String LOG_TAG = "CordovaAllowListPlugin";
+
+    private AllowList allowedNavigations;
+    private AllowList allowedIntents;
+    private AllowList allowedRequests;
+
+    // Used when instantiated via reflection by PluginManager
+    public AllowListPlugin() { }
+
+    // These can be used by embedders to allow Java-configuration of an allow list.
+    public AllowListPlugin(Context context) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(context);
+    }
+
+    public AllowListPlugin(XmlPullParser xmlParser) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(xmlParser);
+    }
+
+    public AllowListPlugin(AllowList allowedNavigations, AllowList allowedIntents, AllowList allowedRequests) {
+        if (allowedRequests == null) {
+            allowedRequests = new AllowList();
+            allowedRequests.addAllowListEntry("file:///*", false);
+            allowedRequests.addAllowListEntry("data:*", false);
+        }
+
+        this.allowedNavigations = allowedNavigations;
+        this.allowedIntents = allowedIntents;
+        this.allowedRequests = allowedRequests;
+    }
+
+    @Override
+    public void pluginInitialize() {
+        if (this.allowedNavigations == null) {
+            this.allowedNavigations = new AllowList();
+            this.allowedIntents = new AllowList();
+            this.allowedRequests = new AllowList();
+
+            new CustomConfigXmlParser().parse(webView.getContext());
+        }
+    }
+
+    private class CustomConfigXmlParser extends ConfigXmlParser {
+        @Override
+        public void handleStartTag(XmlPullParser xml) {
+            String strNode = xml.getName();
+            if (strNode.equals("content")) {
+                String startPage = xml.getAttributeValue(null, "src");
+                allowedNavigations.addAllowListEntry(startPage, false);
+            } else if (strNode.equals("allow-navigation")) {
+                String origin = xml.getAttributeValue(null, "href");
+                if ("*".equals(origin)) {
+                    allowedNavigations.addAllowListEntry("http://*/*", false);
+                    allowedNavigations.addAllowListEntry("https://*/*", false);
+                    allowedNavigations.addAllowListEntry("data:*", false);
+                } else {
+                    allowedNavigations.addAllowListEntry(origin, false);
+                }
+            } else if (strNode.equals("allow-intent")) {
+                String origin = xml.getAttributeValue(null, "href");
+                allowedIntents.addAllowListEntry(origin, false);
+            } else if (strNode.equals("access")) {
+                String origin = xml.getAttributeValue(null, "origin");
+                String subdomains = xml.getAttributeValue(null, "subdomains");
+                boolean external = (xml.getAttributeValue(null, "launch-external") != null);
+                if (origin != null) {
+                    if (external) {
+                        LOG.w(LOG_TAG, "Found <access launch-external> within config.xml. Please use <allow-intent> instead.");

Review comment:
       Yes, we can remove this now too... I didn't carefully read to notice that this deprecated code existed. I will go ahead and delete this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu commented on pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
erisu commented on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-738526922


   Yes, because the core's original classname was renamed, this is a major change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer commented on a change in pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on a change in pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#discussion_r662090072



##########
File path: test/androidx/app/src/main/assets/www/whitelist/index.html
##########
@@ -27,7 +27,7 @@
       <script type="text/javascript" charset="utf-8" src="../main.js"></script>

Review comment:
       Maybe this file should be in the folder `www/allowlist/index.html` instead of  `www/whitelist/index.html`?

##########
File path: test/android/app/src/main/assets/www/index.html
##########
@@ -0,0 +1,56 @@
+<!--

Review comment:
       Should this be in the `test/androidx` directory instead of the `test/android` folder ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-commenter edited a comment on pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-872033411


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1138](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c3f59c) into [master](https://codecov.io/gh/apache/cordova-android/commit/0f13f4a5ac8e657aee9ee52f1aabf1c59ccdf3b9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f13f4a) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1138/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1138   +/-   ##
   =======================================
     Coverage   71.90%   71.90%           
   =======================================
     Files          21       21           
     Lines        1694     1694           
   =======================================
     Hits         1218     1218           
     Misses        476      476           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0f13f4a...8c3f59c](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] NiklasMerz commented on pull request #1138: feat(allow-list)!: integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-1052601191


   @dalyboub Please go to Stack Overflow or [Slack](http://slack.cordova.io/) for questions.
   
   Issues and pullrequests are not for questions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu commented on a change in pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#discussion_r662168477



##########
File path: test/android/app/src/main/assets/www/index.html
##########
@@ -0,0 +1,56 @@
+<!--

Review comment:
       I deleted this file. It is not needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] NiklasMerz commented on pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-839479640


   Should we resolve the conflicts and move forward with this? Especially as we should solve #1217 after merging this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu commented on a change in pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#discussion_r662168367



##########
File path: test/androidx/app/src/main/assets/www/whitelist/index.html
##########
@@ -27,7 +27,7 @@
       <script type="text/javascript" charset="utf-8" src="../main.js"></script>

Review comment:
       Yes, the renaming of this directory was forgotten. I applied fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] dpogue commented on a change in pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
dpogue commented on a change in pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#discussion_r533896184



##########
File path: framework/src/org/apache/cordova/AllowListPlugin.java
##########
@@ -0,0 +1,162 @@
+/*
+       Licensed to the Apache Software Foundation (ASF) under one
+       or more contributor license agreements.  See the NOTICE file
+       distributed with this work for additional information
+       regarding copyright ownership.  The ASF licenses this file
+       to you under the Apache License, Version 2.0 (the
+       "License"); you may not use this file except in compliance
+       with the License.  You may obtain a copy of the License at
+
+         http://www.apache.org/licenses/LICENSE-2.0
+
+       Unless required by applicable law or agreed to in writing,
+       software distributed under the License is distributed on an
+       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+       KIND, either express or implied.  See the License for the
+       specific language governing permissions and limitations
+       under the License.
+*/
+
+package org.apache.cordova;
+
+import org.apache.cordova.CordovaPlugin;
+import org.apache.cordova.ConfigXmlParser;
+import org.apache.cordova.LOG;
+import org.apache.cordova.AllowList;
+import org.xmlpull.v1.XmlPullParser;
+
+import android.content.Context;
+
+public class AllowListPlugin extends CordovaPlugin {
+    public static final String PLUGIN_NAME = "CordovaAllowListPlugin";
+    protected static final String LOG_TAG = "CordovaAllowListPlugin";
+
+    private AllowList allowedNavigations;
+    private AllowList allowedIntents;
+    private AllowList allowedRequests;
+
+    // Used when instantiated via reflection by PluginManager
+    public AllowListPlugin() { }
+
+    // These can be used by embedders to allow Java-configuration of an allow list.
+    public AllowListPlugin(Context context) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(context);
+    }
+
+    public AllowListPlugin(XmlPullParser xmlParser) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(xmlParser);
+    }
+
+    public AllowListPlugin(AllowList allowedNavigations, AllowList allowedIntents, AllowList allowedRequests) {
+        if (allowedRequests == null) {
+            allowedRequests = new AllowList();
+            allowedRequests.addAllowListEntry("file:///*", false);
+            allowedRequests.addAllowListEntry("data:*", false);
+        }
+
+        this.allowedNavigations = allowedNavigations;
+        this.allowedIntents = allowedIntents;
+        this.allowedRequests = allowedRequests;
+    }
+
+    @Override
+    public void pluginInitialize() {
+        if (this.allowedNavigations == null) {
+            this.allowedNavigations = new AllowList();
+            this.allowedIntents = new AllowList();
+            this.allowedRequests = new AllowList();
+
+            new CustomConfigXmlParser().parse(webView.getContext());
+        }
+    }
+
+    private class CustomConfigXmlParser extends ConfigXmlParser {
+        @Override
+        public void handleStartTag(XmlPullParser xml) {
+            String strNode = xml.getName();
+            if (strNode.equals("content")) {
+                String startPage = xml.getAttributeValue(null, "src");
+                allowedNavigations.addAllowListEntry(startPage, false);
+            } else if (strNode.equals("allow-navigation")) {
+                String origin = xml.getAttributeValue(null, "href");
+                if ("*".equals(origin)) {
+                    allowedNavigations.addAllowListEntry("http://*/*", false);
+                    allowedNavigations.addAllowListEntry("https://*/*", false);
+                    allowedNavigations.addAllowListEntry("data:*", false);
+                } else {
+                    allowedNavigations.addAllowListEntry(origin, false);
+                }
+            } else if (strNode.equals("allow-intent")) {
+                String origin = xml.getAttributeValue(null, "href");
+                allowedIntents.addAllowListEntry(origin, false);
+            } else if (strNode.equals("access")) {
+                String origin = xml.getAttributeValue(null, "origin");
+                String subdomains = xml.getAttributeValue(null, "subdomains");
+                boolean external = (xml.getAttributeValue(null, "launch-external") != null);
+                if (origin != null) {
+                    if (external) {
+                        LOG.w(LOG_TAG, "Found <access launch-external> within config.xml. Please use <allow-intent> instead.");

Review comment:
       Now seems like a good time to drop this deprecated `<access launch-external>` support?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-commenter commented on pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-872033411


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1138](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8c3f59c) into [master](https://codecov.io/gh/apache/cordova-android/commit/0f13f4a5ac8e657aee9ee52f1aabf1c59ccdf3b9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0f13f4a) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1138/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1138   +/-   ##
   =======================================
     Coverage   71.90%   71.90%           
   =======================================
     Files          21       21           
     Lines        1694     1694           
   =======================================
     Hits         1218     1218           
     Misses        476      476           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0f13f4a...8c3f59c](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] dalybouba removed a comment on pull request #1138: feat(allow-list)!: integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
dalybouba removed a comment on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-1049779943


   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\device\Device.java:30: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\dialogs\Notification.java:20: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\file\AssetFilesystem.java:23: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\filetransfer\FileTransfer.java:40: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\firebase\FirebasePlugin.java:16: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\geolocation\Geolocation.java:24: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] 6 errors
   [cordova]
   [cordova] FAILURE: Build failed with an exception.
   [cordova]
   [cordova] * What went wrong:
   [cordova] Execution failed for task ':app:compileDebugJavaWithJavac'.
   [cordova] > Compilation failed; see the compiler error output for details.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] dalybouba commented on pull request #1138: feat(allow-list)!: integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
dalybouba commented on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-1049779943


   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\device\Device.java:30: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\dialogs\Notification.java:20: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\file\AssetFilesystem.java:23: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\filetransfer\FileTransfer.java:40: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\firebase\FirebasePlugin.java:16: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\org\apache\cordova\geolocation\Geolocation.java:24: error: ';' expected
   [cordova] import org.apache.cordova.AllowList
   [cordova]                                    ^
   [cordova] 6 errors
   [cordova]
   [cordova] FAILURE: Build failed with an exception.
   [cordova]
   [cordova] * What went wrong:
   [cordova] Execution failed for task ':app:compileDebugJavaWithJavac'.
   [cordova] > Compilation failed; see the compiler error output for details.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu commented on a change in pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#discussion_r533933504



##########
File path: framework/src/org/apache/cordova/AllowListPlugin.java
##########
@@ -0,0 +1,162 @@
+/*
+       Licensed to the Apache Software Foundation (ASF) under one
+       or more contributor license agreements.  See the NOTICE file
+       distributed with this work for additional information
+       regarding copyright ownership.  The ASF licenses this file
+       to you under the Apache License, Version 2.0 (the
+       "License"); you may not use this file except in compliance
+       with the License.  You may obtain a copy of the License at
+
+         http://www.apache.org/licenses/LICENSE-2.0
+
+       Unless required by applicable law or agreed to in writing,
+       software distributed under the License is distributed on an
+       "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+       KIND, either express or implied.  See the License for the
+       specific language governing permissions and limitations
+       under the License.
+*/
+
+package org.apache.cordova;
+
+import org.apache.cordova.CordovaPlugin;
+import org.apache.cordova.ConfigXmlParser;
+import org.apache.cordova.LOG;
+import org.apache.cordova.AllowList;
+import org.xmlpull.v1.XmlPullParser;
+
+import android.content.Context;
+
+public class AllowListPlugin extends CordovaPlugin {
+    public static final String PLUGIN_NAME = "CordovaAllowListPlugin";
+    protected static final String LOG_TAG = "CordovaAllowListPlugin";
+
+    private AllowList allowedNavigations;
+    private AllowList allowedIntents;
+    private AllowList allowedRequests;
+
+    // Used when instantiated via reflection by PluginManager
+    public AllowListPlugin() { }
+
+    // These can be used by embedders to allow Java-configuration of an allow list.
+    public AllowListPlugin(Context context) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(context);
+    }
+
+    public AllowListPlugin(XmlPullParser xmlParser) {
+        this(new AllowList(), new AllowList(), null);
+        new CustomConfigXmlParser().parse(xmlParser);
+    }
+
+    public AllowListPlugin(AllowList allowedNavigations, AllowList allowedIntents, AllowList allowedRequests) {
+        if (allowedRequests == null) {
+            allowedRequests = new AllowList();
+            allowedRequests.addAllowListEntry("file:///*", false);
+            allowedRequests.addAllowListEntry("data:*", false);
+        }
+
+        this.allowedNavigations = allowedNavigations;
+        this.allowedIntents = allowedIntents;
+        this.allowedRequests = allowedRequests;
+    }
+
+    @Override
+    public void pluginInitialize() {
+        if (this.allowedNavigations == null) {
+            this.allowedNavigations = new AllowList();
+            this.allowedIntents = new AllowList();
+            this.allowedRequests = new AllowList();
+
+            new CustomConfigXmlParser().parse(webView.getContext());
+        }
+    }
+
+    private class CustomConfigXmlParser extends ConfigXmlParser {
+        @Override
+        public void handleStartTag(XmlPullParser xml) {
+            String strNode = xml.getName();
+            if (strNode.equals("content")) {
+                String startPage = xml.getAttributeValue(null, "src");
+                allowedNavigations.addAllowListEntry(startPage, false);
+            } else if (strNode.equals("allow-navigation")) {
+                String origin = xml.getAttributeValue(null, "href");
+                if ("*".equals(origin)) {
+                    allowedNavigations.addAllowListEntry("http://*/*", false);
+                    allowedNavigations.addAllowListEntry("https://*/*", false);
+                    allowedNavigations.addAllowListEntry("data:*", false);
+                } else {
+                    allowedNavigations.addAllowListEntry(origin, false);
+                }
+            } else if (strNode.equals("allow-intent")) {
+                String origin = xml.getAttributeValue(null, "href");
+                allowedIntents.addAllowListEntry(origin, false);
+            } else if (strNode.equals("access")) {
+                String origin = xml.getAttributeValue(null, "origin");
+                String subdomains = xml.getAttributeValue(null, "subdomains");
+                boolean external = (xml.getAttributeValue(null, "launch-external") != null);
+                if (origin != null) {
+                    if (external) {
+                        LOG.w(LOG_TAG, "Found <access launch-external> within config.xml. Please use <allow-intent> instead.");

Review comment:
       @dpogue The `launch-external` has been removed: https://github.com/apache/cordova-android/pull/1138/commits/4fc48ff5093d0d8b5defc9fa9f58a72dc192d582?diff=split&w=1
   
   I also moved the `String subdomains` into the else statement where it is used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io commented on pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-737032816


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=h1) Report
   > Merging [#1138](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=desc) (4fc48ff) into [master](https://codecov.io/gh/apache/cordova-android/commit/97e2d15634f3c7a37e468cdafcb697257340570c?el=desc) (97e2d15) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1138/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1138      +/-   ##
   ==========================================
   - Coverage   71.19%   71.13%   -0.06%     
   ==========================================
     Files          21       21              
     Lines        1739     1739              
   ==========================================
   - Hits         1238     1237       -1     
   - Misses        501      502       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1138/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `69.75% <0.00%> (-0.49%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=footer). Last update [97e2d15...4fc48ff](https://codecov.io/gh/apache/cordova-android/pull/1138?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu merged pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
erisu merged pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer commented on pull request #1138: feat(allow-list): integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-863568380


   @erisu , @NiklasMerz I did merge the master in this branche and opened a new PR ( https://github.com/apache/cordova-android/pull/1244 ) for this. 
   Feel free to merge it, remove it, review it if you like.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] dalybouba commented on pull request #1138: feat(allow-list)!: integrate and refactor core plugin

Posted by GitBox <gi...@apache.org>.
dalybouba commented on pull request #1138:
URL: https://github.com/apache/cordova-android/pull/1138#issuecomment-1049783411


   please I'm tired with the build anyone can help me please with those issue 👍 
   
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\BackgroundActionButtonHandler.java:9: error: cannot find symbol
   [cordova] import android.support.v4.app.RemoteInput;
   [cordova]                              ^
   [cordova]   symbol:   class RemoteInput
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:26: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:27: error: package android.support.v4.app.NotificationCompat does not
    exist
   [cordova] import android.support.v4.app.NotificationCompat.WearableExtender;
   [cordova]                                                 ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:28: error: cannot find symbol
   [cordova] import android.support.v4.app.RemoteInput;
   [cordova]                              ^
   [cordova]   symbol:   class RemoteInput
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:528: error: package NotificationCompat does not exist
   [cordova]   private void createActions(Bundle extras, NotificationCompat.Builder mBuilder, Resources resources,
   [cordova]                                                               ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:612: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationCount(Context context, Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                       ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:620: error: package NotificationCompat does not exist
   [cordova]   private void setVisibility(Context context, Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:636: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationVibration(Bundle extras, Boolean vibrateOption, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                                 ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:655: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationOngoing(Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                        ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:660: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationMessage(int notId, Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                   ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:731: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationSound(Context context, Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                                       ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:748: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationLedColor(Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:768: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationPriority(Bundle extras, NotificationCompat.Builder mBuilder) {
   [cordova]                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:813: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.Builder mBuilder) {
   [cordova]                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:863: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.Builder mBuilder, String localIcon) {
   [cordova]                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:880: error: package NotificationCompat does not exist
   [cordova]   private void setNotificationIconColor(String color, NotificationCompat.Builder mBuilder, String localIconColor) {
   [cordova]                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushHandlerActivity.java:10: error: cannot find symbol
   [cordova] import android.support.v4.app.RemoteInput;
   [cordova]                              ^
   [cordova]   symbol:   class RemoteInput
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:15: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:16: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationManagerCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationManagerCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\evgenii\jsevaluator\JsEvaluator.java:4: error: package android.support.annotation does not exist
   [cordova] import android.support.annotation.VisibleForTesting;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:17: error: package android.support.v4.content does not
    exist
   [cordova] import android.support.v4.content.ContextCompat;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:18: error: package android.support.v4.content does not
    exist
   [cordova] import android.support.v4.content.LocalBroadcastManager;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\Config.java:15: error: package android.support.annotation does not exist
   [cordova] import android.support.annotation.Nullable;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\BackgroundLocation.java:10: error: package android.support.v4.util does not exist
   [cordova] import android.support.v4.util.TimeUtils;
   [cordova]                               ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:4: error: package android.support.annotation does not exist
   [cordova] import android.support.annotation.NonNull;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:5: error: package android.support.annotation does not exist
   [cordova] import android.support.annotation.Nullable;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:32: error: package android.support.annotation does not
    exist
   [cordova] import android.support.annotation.Nullable;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:33: error: package android.support.v4.content does not
    exist
   [cordova] import android.support.v4.content.LocalBroadcastManager;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceIntentBuilder.java:24: error: package android.support.annotation
    does not exist
   [cordova] import android.support.annotation.IntDef;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceIntentBuilder.java:31: error: cannot find symbol
   [cordova] @IntDef({
   [cordova]  ^
   [cordova]   symbol: class IntDef
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:12: error: package android.support.annotation does not exi
   st
   [cordova] import android.support.annotation.RequiresApi;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:13: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:14: error: cannot find symbol
   [cordova] import android.support.v4.app.NotificationCompat;
   [cordova]                              ^
   [cordova]   symbol:   class NotificationCompat
   [cordova]   location: package android.support.v4.app
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:15: error: package android.support.v4.content does not exist
   [cordova] import android.support.v4.content.LocalBroadcastManager;
   [cordova]                                  ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\evgenii\jsevaluator\JsEvaluator.java:118: error: cannot find symbol
   [cordova]       @VisibleForTesting
   [cordova]        ^
   [cordova]   symbol:   class VisibleForTesting
   [cordova]   location: class JsEvaluator
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\evgenii\jsevaluator\JsEvaluator.java:123: error: cannot find symbol
   [cordova]       @VisibleForTesting
   [cordova]        ^
   [cordova]   symbol:   class VisibleForTesting
   [cordova]   location: class JsEvaluator
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\evgenii\jsevaluator\JsEvaluator.java:128: error: cannot find symbol
   [cordova]       @VisibleForTesting
   [cordova]        ^
   [cordova]   symbol:   class VisibleForTesting
   [cordova]   location: class JsEvaluator
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\Config.java:355: error: cannot find symbol
   [cordova]     @Nullable
   [cordova]      ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: class Config
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\Config.java:360: error: cannot find symbol
   [cordova]     public void setNotificationsEnabled(@Nullable Boolean notificationsEnabled) {
   [cordova]                                          ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: class Config
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:20: error: cannot find symbol
   [cordova]     BackgroundLocation transformLocationBeforeCommit(@NonNull Context context, @NonNull BackgroundLocation location);
   [cordova]                                                       ^
   [cordova]   symbol:   class NonNull
   [cordova]   location: interface LocationTransform
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:20: error: cannot find symbol
   [cordova]     BackgroundLocation transformLocationBeforeCommit(@NonNull Context context, @NonNull BackgroundLocation location);
   [cordova]                                                                                 ^
   [cordova]   symbol:   class NonNull
   [cordova]   location: interface LocationTransform
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\LocationTransform.java:19: error: cannot find symbol
   [cordova]     @Nullable
   [cordova]      ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: interface LocationTransform
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:739: error: cannot find symbol
   [cordova]     public static void setLocationTransform(@Nullable LocationTransform transform) {
   [cordova]                                              ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: class LocationServiceImpl
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:743: error: cannot find symbol
   [cordova]     public static @Nullable LocationTransform getLocationTransform() {
   [cordova]                    ^
   [cordova]   symbol:   class Nullable
   [cordova]   location: class LocationServiceImpl
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:119: error: cannot find symbol
   [cordova]     @RequiresApi(api = Build.VERSION_CODES.O)
   [cordova]      ^
   [cordova]   symbol:   class RequiresApi
   [cordova]   location: class NotificationHelper
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:126: error: cannot find symbol
   [cordova]     @RequiresApi(api = Build.VERSION_CODES.O)
   [cordova]      ^
   [cordova]   symbol:   class RequiresApi
   [cordova]   location: class NotificationHelper
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:134: error: cannot find symbol
   [cordova]     @RequiresApi(api = Build.VERSION_CODES.O)
   [cordova]      ^
   [cordova]   symbol:   class RequiresApi
   [cordova]   location: class NotificationHelper
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\BackgroundActionButtonHandler.java:31: error: cannot find symbol
   [cordova]             Bundle remoteInput = RemoteInput.getResultsFromIntent(intent);
   [cordova]                                  ^
   [cordova]   symbol:   variable RemoteInput
   [cordova]   location: class BackgroundActionButtonHandler
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:395: error: package NotificationCompat does not exist
   [cordova]     NotificationCompat.Builder mBuilder = null;
   [cordova]                       ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:402: error: package NotificationCompat does not exist
   [cordova]         mBuilder = new NotificationCompat.Builder(context, channelID);
   [cordova]                                          ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:412: error: package NotificationCompat does not exist
   [cordova]         mBuilder = new NotificationCompat.Builder(context, channelID);
   [cordova]                                          ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:416: error: package NotificationCompat does not exist
   [cordova]       mBuilder = new NotificationCompat.Builder(context);
   [cordova]                                        ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:535: error: package NotificationCompat does not exist
   [cordova]         ArrayList<NotificationCompat.Action> wActions = new ArrayList<NotificationCompat.Action>();
   [cordova]                                     ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:535: error: package NotificationCompat does not exist
   [cordova]         ArrayList<NotificationCompat.Action> wActions = new ArrayList<NotificationCompat.Action>();
   [cordova]                                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:581: error: package NotificationCompat.Action does not exist
   [cordova]           NotificationCompat.Action.Builder actionBuilder = new NotificationCompat.Action.Builder(
   [cordova]                                    ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:581: error: package NotificationCompat.Action does not exist
   [cordova]           NotificationCompat.Action.Builder actionBuilder = new NotificationCompat.Action.Builder(
   [cordova]                                                                                          ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:584: error: cannot find symbol
   [cordova]           RemoteInput remoteInput = null;
   [cordova]           ^
   [cordova]   symbol:   class RemoteInput
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:588: error: package RemoteInput does not exist
   [cordova]             remoteInput = new RemoteInput.Builder(INLINE_REPLY).setLabel(replyLabel).build();
   [cordova]                                          ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:592: error: package NotificationCompat does not exist
   [cordova]           NotificationCompat.Action wAction = actionBuilder.build();
   [cordova]                             ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:604: error: cannot find symbol
   [cordova]         mBuilder.extend(new WearableExtender().addActions(wActions));
   [cordova]                             ^
   [cordova]   symbol:   class WearableExtender
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:625: error: cannot find symbol
   [cordova]         if (visibility >= NotificationCompat.VISIBILITY_SECRET && visibility <= NotificationCompat.VISIBILITY_PUBLIC) {
   [cordova]                           ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:625: error: cannot find symbol
   [cordova]         if (visibility >= NotificationCompat.VISIBILITY_SECRET && visibility <= NotificationCompat.VISIBILITY_PUBLIC) {
   [cordova]                                                                                 ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:677: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.InboxStyle notificationInbox = new NotificationCompat.InboxStyle()
   [cordova]                           ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:677: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.InboxStyle notificationInbox = new NotificationCompat.InboxStyle()
   [cordova]                                                                                 ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:686: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.BigTextStyle bigText = new NotificationCompat.BigTextStyle();
   [cordova]                           ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:686: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.BigTextStyle bigText = new NotificationCompat.BigTextStyle();
   [cordova]                                                                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:696: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.BigPictureStyle bigPicture = new NotificationCompat.BigPictureStyle();
   [cordova]                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:696: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.BigPictureStyle bigPicture = new NotificationCompat.BigPictureStyle();
   [cordova]                                                                             ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:708: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.BigTextStyle bigText = new NotificationCompat.BigTextStyle();
   [cordova]                         ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:708: error: package NotificationCompat does not exist
   [cordova]       NotificationCompat.BigTextStyle bigText = new NotificationCompat.BigTextStyle();
   [cordova]                                                                       ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:773: error: cannot find symbol
   [cordova]         if (priority >= NotificationCompat.PRIORITY_MIN && priority <= NotificationCompat.PRIORITY_MAX) {
   [cordova]                         ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\FCMService.java:773: error: cannot find symbol
   [cordova]         if (priority >= NotificationCompat.PRIORITY_MIN && priority <= NotificationCompat.PRIORITY_MAX) {
   [cordova]                                                                        ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class FCMService
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushHandlerActivity.java:87: error: cannot find symbol
   [cordova]             remoteInput = RemoteInput.getResultsFromIntent(intent);
   [cordova]                           ^
   [cordova]   symbol:   variable RemoteInput
   [cordova]   location: class PushHandlerActivity
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:105: error: cannot find symbol
   [cordova]       int visibility = channel.optInt(VISIBILITY, NotificationCompat.VISIBILITY_PUBLIC);
   [cordova]                                                   ^
   [cordova]   symbol:   variable NotificationCompat
   [cordova]   location: class PushPlugin
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:322: error: cannot find symbol
   [cordova]                 "has permission: " + NotificationManagerCompat.from(getApplicationContext()).areNotificationsEnabled());
   [cordova]                                      ^
   [cordova]   symbol: variable NotificationManagerCompat
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\adobe\phonegap\push\PushPlugin.java:323: error: cannot find symbol
   [cordova]             jo.put("isEnabled", NotificationManagerCompat.from(getApplicationContext()).areNotificationsEnabled());
   [cordova]                                 ^
   [cordova]   symbol: variable NotificationManagerCompat
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:199: error: cannot find symbol
   [cordova]         LocalBroadcastManager.getInstance(getContext()).registerReceiver(serviceBroadcastReceiver, new IntentFilter(LocationServiceImpl.ACTION_BROADCAST));
   [cordova]         ^
   [cordova]   symbol:   variable LocalBroadcastManager
   [cordova]   location: class BackgroundGeolocationFacade
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:208: error: cannot find symbol
   [cordova]             LocalBroadcastManager.getInstance(context).unregisterReceiver(serviceBroadcastReceiver);
   [cordova]             ^
   [cordova]   symbol:   variable LocalBroadcastManager
   [cordova]   location: class BackgroundGeolocationFacade
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\BackgroundGeolocationFacade.java:489: error: cannot find symbol
   [cordova]             if (ContextCompat.checkSelfPermission(context, perm) != PackageManager.PERMISSION_GRANTED) {
   [cordova]                 ^
   [cordova]   symbol:   variable ContextCompat
   [cordova]   location: class BackgroundGeolocationFacade
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\BackgroundLocation.java:824: error: cannot find symbol
   [cordova]             TimeUtils.formatDuration(elapsedRealtimeNanos / 1000000L, s);
   [cordova]             ^
   [cordova]   symbol:   variable TimeUtils
   [cordova]   location: class BackgroundLocation
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\data\BackgroundActivity.java:20: error: cannot access zzbfm
   [cordova]         confidence = activity.getConfidence();
   [cordova]                              ^
   [cordova]   class file for com.google.android.gms.internal.zzbfm not found
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\service\LocationServiceImpl.java:628: error: cannot find symbol
   [cordova]         LocalBroadcastManager.getInstance(getApplicationContext()).sendBroadcast(intent);
   [cordova]         ^
   [cordova]   symbol:   variable LocalBroadcastManager
   [cordova]   location: class LocationServiceImpl
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:55: error: package NotificationCompat does not exist
   [cordova]             NotificationCompat.Builder builder = new NotificationCompat.Builder(mContext, NotificationHelper.SERVICE_CHANNEL_ID);
   [cordova]                               ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\NotificationHelper.java:55: error: package NotificationCompat does not exist
   [cordova]             NotificationCompat.Builder builder = new NotificationCompat.Builder(mContext, NotificationHelper.SERVICE_CHANNEL_ID);
   [cordova]                                                                        ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:144: error: package NotificationCompat does not exist
   [cordova]         NotificationCompat.Builder builder = null;
   [cordova]                           ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:147: error: package NotificationCompat does not exist
   [cordova]             builder = new NotificationCompat.Builder(getContext(), NotificationHelper.SYNC_CHANNEL_ID);
   [cordova]                                             ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:218: error: package NotificationCompat does not exist
   [cordova]             NotificationCompat.Builder builder = new NotificationCompat.Builder(getContext(), NotificationHelper.SYNC_CHANNEL_ID);
   [cordova]                               ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:218: error: package NotificationCompat does not exist
   [cordova]             NotificationCompat.Builder builder = new NotificationCompat.Builder(getContext(), NotificationHelper.SYNC_CHANNEL_ID);
   [cordova]                                                                        ^
   [cordova] C:\repo\ONATROUVER\onatrouveIO5\platforms\android\app\src\main\java\com\marianhello\bgloc\sync\SyncAdapter.java:231: error: cannot find symbol
   [cordova]         LocalBroadcastManager.getInstance(getContext().getApplicationContext()).sendBroadcast(intent);
   [cordova]         ^
   [cordova]   symbol:   variable LocalBroadcastManager
   [cordova]   location: class SyncAdapter
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org