[GitHub] [incubator-iotdb] haimeiguo commented on a change in pull request #1665: IOTDB-851: enhance failure tolerance when recover WAL

[GitBox <gi...@apache.org>]

haimeiguo commented on a change in pull request #1665:
URL: https://github.com/apache/incubator-iotdb/pull/1665#discussion_r483935258



##########
File path: server/src/main/java/org/apache/iotdb/db/writelog/recover/LogReplayer.java
##########
@@ -164,11 +164,17 @@ private void replayInsert(InsertPlan plan) throws WriteProcessException, QueryPr
     }
     if (plan instanceof InsertRowPlan) {
       InsertRowPlan tPlan = (InsertRowPlan) plan;
+      //only infer type when users pass a String value
+      //WAL already serializes the real data type, so no need to infer type
+      ((InsertRowPlan) plan).setNeedInferType(false);
       tPlan.setSchemasAndTransferType(schemas);
+      //mark failed plan manually 
+      checkDataTypeAndMarkFailed(schemas, tPlan);

Review comment:
       Hi thank you for your review! 
   Here i set plan.setNeedInferType(false)
   in setSchemasAndTransferType(schemas), it will only execute this.schemas = schemas
   it will not mark the data points as failed
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org