You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "ralf0131 (GitHub)" <gi...@apache.org> on 2019/03/07 03:45:06 UTC

[GitHub] [incubator-dubbo] ralf0131 opened pull request #3605: [Dubbo-808] Support etcd registry

## What is the purpose of the change

This pull request add the support for etcd as registry. #808 

## Brief changelog

1. merge code from https://github.com/dubbo/dubbo-registry-etcd into incubator-dubbo.
2. Update all the unit test from Junit 4 to Junit 5
3. Remove all the author info
4. Fix some typo

Note that all the Unit test seem to be disabled. 

## Verifying this change

Write a demo application and verified provider and consumer could work with etcd as reigstry.

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [x] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3605: [Dubbo-808] Support etcd registry

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=h1) Report
> Merging [#3605](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/096d1dae2adc86be71076a53c1ded690cc5b4997?src=pr&el=desc) will **decrease** coverage by `1.18%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3605      +/-   ##
============================================
- Coverage     65.13%   63.94%   -1.19%     
  Complexity       71       71              
============================================
  Files           691      700       +9     
  Lines         30110    30684     +574     
  Branches       4890     4973      +83     
============================================
+ Hits          19613    19622       +9     
- Misses         8234     8798     +564     
- Partials       2263     2264       +1
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...pache/dubbo/remoting/etcd/AbstractRetryPolicy.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvQWJzdHJhY3RSZXRyeVBvbGljeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/etcd/jetcd/RetryNTimes.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvUmV0cnlOVGltZXMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...he/dubbo/remoting/etcd/jetcd/JEtcdTransporter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RUcmFuc3BvcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...g/apache/dubbo/remoting/etcd/option/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvb3B0aW9uL0NvbnN0YW50cy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/etcd/option/OptionUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvb3B0aW9uL09wdGlvblV0aWwuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...g/apache/dubbo/remoting/etcd/jetcd/RetryLoops.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvUmV0cnlMb29wcy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ubbo/remoting/etcd/support/AbstractEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvc3VwcG9ydC9BYnN0cmFjdEV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| ... and [15 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=footer). Last update [096d1da...2e75c0a](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zonghaishang commented on issue #3605: [Dubbo-808] Support etcd registry

Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
> https://github.com/etcd-io/jetcd#launcher
> 
> The `io.etcd:jetcd-launcher` offers a convenient utility to programmatically start & stop an isolated etcd server. This can be very useful e.g. for integration testing, like so:
> 
> ```java
> @Rule public final EtcdClusterResource etcd = new EtcdClusterResource("test-etcd", 1);
> Client client = Client.builder().endpoints(etcd.cluster().getClientEndpoints()).build();
> ```
> 
> This library is something that worth further investigation.

nice !!!

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3605: [Dubbo-808] Support etcd registry

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=h1) Report
> Merging [#3605](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6a7028446bcd76ec75c742ab283c7dc5675144e7?src=pr&el=desc) will **decrease** coverage by `1.26%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3605      +/-   ##
============================================
- Coverage      64.2%   62.94%   -1.27%     
  Complexity       71       71              
============================================
  Files           664      673       +9     
  Lines         28653    29227     +574     
  Branches       4769     4852      +83     
============================================
- Hits          18398    18396       -2     
- Misses         8033     8609     +576     
  Partials       2222     2222
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/dubbo/remoting/etcd/option/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvb3B0aW9uL0NvbnN0YW50cy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...pache/dubbo/remoting/etcd/AbstractRetryPolicy.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvQWJzdHJhY3RSZXRyeVBvbGljeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/etcd/jetcd/RetryNTimes.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvUmV0cnlOVGltZXMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...he/dubbo/remoting/etcd/jetcd/JEtcdTransporter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RUcmFuc3BvcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/etcd/option/OptionUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvb3B0aW9uL09wdGlvblV0aWwuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...g/apache/dubbo/remoting/etcd/jetcd/RetryLoops.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvUmV0cnlMb29wcy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ubbo/remoting/etcd/support/AbstractEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvc3VwcG9ydC9BYnN0cmFjdEV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...e/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eUNoYW5uZWwuamF2YQ==) | `57.64% <0%> (-4.71%)` | `0% <0%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=footer). Last update [6a70284...b4b9be2](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3605: [Dubbo-808] Support etcd registry

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
Yes, it is an issue, as I mentioned it in the description, the UT is disabled by default. I do think unit test is necessary. This pull request tries to minimize the change when migrating the code.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] ralf0131 commented on issue #3605: [Dubbo-808] Support etcd registry

Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
https://github.com/etcd-io/jetcd#launcher

The `io.etcd:jetcd-launcher` offers a convenient utility to programmatically start & stop an isolated etcd server. This can be very useful e.g. for integration testing, like so:

```java
@Rule public final EtcdClusterResource etcd = new EtcdClusterResource("test-etcd", 1);
Client client = Client.builder().endpoints(etcd.cluster().getClientEndpoints()).build();
```

This library is something that worth further investigation.

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] htynkn commented on issue #3605: [Dubbo-808] Support etcd registry

Posted by "htynkn (GitHub)" <gi...@apache.org>.
I also notice that even test coverage decrease more than 1%, it still says All checks have passed. I guess coverage check configuration doesnt work at all....

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #3605: [Dubbo-808] Support etcd registry

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=h1) Report
> Merging [#3605](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/6a7028446bcd76ec75c742ab283c7dc5675144e7?src=pr&el=desc) will **decrease** coverage by `1.31%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=tree)

```diff
@@             Coverage Diff              @@
##             master    #3605      +/-   ##
============================================
- Coverage      64.2%   62.89%   -1.32%     
  Complexity       71       71              
============================================
  Files           664      673       +9     
  Lines         28653    29227     +574     
  Branches       4769     4852      +83     
============================================
- Hits          18398    18383      -15     
- Misses         8033     8618     +585     
- Partials       2222     2226       +4
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...g/apache/dubbo/remoting/etcd/option/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvb3B0aW9uL0NvbnN0YW50cy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...pache/dubbo/remoting/etcd/AbstractRetryPolicy.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvQWJzdHJhY3RSZXRyeVBvbGljeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/etcd/jetcd/RetryNTimes.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvUmV0cnlOVGltZXMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...he/dubbo/remoting/etcd/jetcd/JEtcdTransporter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RUcmFuc3BvcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../apache/dubbo/remoting/etcd/option/OptionUtil.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvb3B0aW9uL09wdGlvblV0aWwuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...g/apache/dubbo/remoting/etcd/jetcd/RetryLoops.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvUmV0cnlMb29wcy5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../dubbo/remoting/etcd/jetcd/JEtcdClientWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2QvamV0Y2QvSkV0Y2RDbGllbnRXcmFwcGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...ubbo/remoting/etcd/support/AbstractEtcdClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctZXRjZDMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL2V0Y2Qvc3VwcG9ydC9BYnN0cmFjdEV0Y2RDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5U2VydmVySGFuZGxlci5qYXZh) | `61.9% <0%> (-9.53%)` | `0% <0%> (ø)` | |
| ... and [18 more](https://codecov.io/gh/apache/incubator-dubbo/pull/3605/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=footer). Last update [6a70284...9ac8c61](https://codecov.io/gh/apache/incubator-dubbo/pull/3605?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] lovepoem commented on issue #3605: [Dubbo-808] Support etcd registry

Posted by "lovepoem (GitHub)" <gi...@apache.org>.
>  - Coverage      64.2%   62.94%   -1.27%    will decrease coverage by 1.27%.


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] zonghaishang closed pull request #3605: [Dubbo-808] Support etcd registry

Posted by "zonghaishang (GitHub)" <gi...@apache.org>.
[ pull request closed by zonghaishang ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3605 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org