You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nutch.apache.org by le...@apache.org on 2012/02/20 15:23:11 UTC
svn commit: r1291278 - in /nutch/trunk/src/java/org/apache/nutch/fetcher:
Fetcher.java OldFetcher.java
Author: lewismc
Date: Mon Feb 20 14:23:10 2012
New Revision: 1291278
URL: http://svn.apache.org/viewvc?rev=1291278&view=rev
Log:
trivial commit to properly annotate fallthrough scenarios in break statements, hence supressing the warnings.
Modified:
nutch/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java
nutch/trunk/src/java/org/apache/nutch/fetcher/OldFetcher.java
Modified: nutch/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java
URL: http://svn.apache.org/viewvc/nutch/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java?rev=1291278&r1=1291277&r2=1291278&view=diff
==============================================================================
--- nutch/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java (original)
+++ nutch/trunk/src/java/org/apache/nutch/fetcher/Fetcher.java Mon Feb 20 14:23:10 2012
@@ -373,7 +373,7 @@ public class Fetcher extends Configured
FetchItemQueue fiq = getFetchItemQueue(it.queueID);
fiq.addFetchItem(it);
totalSize.incrementAndGet();
- }
+ }nutch jira
public void finishFetchItem(FetchItem it) {
finishFetchItem(it, false);
@@ -789,7 +789,8 @@ public class Fetcher extends Configured
int killedURLs = fetchQueues.checkExceptionThreshold(fit.getQueueID());
if (killedURLs!=0)
reporter.incrCounter("FetcherStatus", "AboveExceptionThresholdInQueue", killedURLs);
- /* FALLTHROUGH */
+
+ @SuppressWarnings("fallthrough")
case ProtocolStatus.RETRY: // retry
case ProtocolStatus.BLOCKED:
output(fit.url, fit.datum, null, status, CrawlDatum.STATUS_FETCH_RETRY);
Modified: nutch/trunk/src/java/org/apache/nutch/fetcher/OldFetcher.java
URL: http://svn.apache.org/viewvc/nutch/trunk/src/java/org/apache/nutch/fetcher/OldFetcher.java?rev=1291278&r1=1291277&r2=1291278&view=diff
==============================================================================
--- nutch/trunk/src/java/org/apache/nutch/fetcher/OldFetcher.java (original)
+++ nutch/trunk/src/java/org/apache/nutch/fetcher/OldFetcher.java Mon Feb 20 14:23:10 2012
@@ -208,7 +208,8 @@ public class OldFetcher extends Configur
// failures - increase the retry counter
case ProtocolStatus.EXCEPTION:
logError(url, status.getMessage());
- /* FALLTHROUGH */
+
+ @SuppressWarnings("fallthrough")
case ProtocolStatus.RETRY: // retry
case ProtocolStatus.WOULDBLOCK:
case ProtocolStatus.BLOCKED: