[GitHub] [spark] cloud-fan commented on a change in pull request #27455: [SPARK-30729][CORE] Eagerly filter out zombie TaskSetManager before offering resources

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27455: [SPARK-30729][CORE] Eagerly filter out zombie TaskSetManager before offering resources
URL: https://github.com/apache/spark/pull/27455#discussion_r375123621
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala
 ##########
 @@ -1082,6 +1083,7 @@ private[spark] class TaskSetManager(
   }
 
   def recomputeLocality(): Unit = {
+    if (isZombie) return
 
 Review comment:
   shall we avoid calling `executorLost` for zombie TSM?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org