[GitHub] [ignite-3] alievmirza commented on a diff in pull request #936: IGNITE-16676 Parallel start of raft groups

[GitBox <gi...@apache.org>]

alievmirza commented on code in PR #936:
URL: https://github.com/apache/ignite-3/pull/936#discussion_r921908865


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -260,6 +268,14 @@ public TableManager(
 
         rebalanceScheduler = new ScheduledThreadPoolExecutor(REBALANCE_SCHEDULER_POOL_SIZE,
                 new NamedThreadFactory("rebalance-scheduler", LOG));
+
+        ioExecutor = new ThreadPoolExecutor(
+                25,
+                Integer.MAX_VALUE,
+                100,
+                TimeUnit.MILLISECONDS,
+                new LinkedBlockingQueue<>(),
+                new NamedThreadFactory("tableManager-io", LOG));

Review Comment:
   seems like LOG should also be on a new line 



##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/server/impl/JraftServerImpl.java:
##########
@@ -456,6 +485,25 @@ public void stopBlockMessages(String groupId) {
         client.stopBlock();
     }
 
+    /**
+     * Initialize (if needed) and receive per-group lock,

Review Comment:
   let's mention here that this is a raft group



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org