[GitHub] [spark] cloud-fan commented on a change in pull request #24469: [SPARK-27576][SQL] table capability to skip the output column resolution

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24469: [SPARK-27576][SQL] table capability to skip the output column resolution
URL: https://github.com/apache/spark/pull/24469#discussion_r281086466
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/NamedRelation.scala
 ##########
 @@ -21,4 +21,7 @@ import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
 
 trait NamedRelation extends LogicalPlan {
   def name: String
+
+  // When true, the schema of input data must match the schema of this relation, during write.
+  def requireSchemaMatch: Boolean = true
 
 Review comment:
   Moving DS v2 to catalyst module should be done soon, we can wait for it. BTW do we still need `NamedRelation` after that? It looks to me that `NamedRelation` is mostly for testing. Currently only the v2 relation class extends it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org