You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2016/01/27 21:38:30 UTC

Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42866/
-----------------------------------------------------------

Review request for mesos and Timothy Chen.


Repository: mesos


Description
-------

It has shown flaky behavior and needs further investigation. Disabling now as
its not a very important test for functionality.


Diffs
-----

  src/tests/containerizer/provisioner_docker_tests.cpp 33df60065903228749833bbad20449ba8784594a 

Diff: https://reviews.apache.org/r/42866/diff/


Testing
-------

make check.


Thanks,

Jojy Varghese


Re: Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42866/#review116664
-----------------------------------------------------------



Patch looks great!

Reviews applied: [42866]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 8:38 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42866/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 8:38 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It has shown flaky behavior and needs further investigation. Disabling now as
> its not a very important test for functionality.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 33df60065903228749833bbad20449ba8784594a 
> 
> Diff: https://reviews.apache.org/r/42866/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42866/#review116856
-----------------------------------------------------------


Ship it!




Ship It!

- Timothy Chen


On Jan. 27, 2016, 8:38 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42866/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 8:38 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It has shown flaky behavior and needs further investigation. Disabling now as
> its not a very important test for functionality.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 33df60065903228749833bbad20449ba8784594a 
> 
> Diff: https://reviews.apache.org/r/42866/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>


Re: Review Request 42866: Disabled the test RegistryClientTest.BadTokenServerAddress.

Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42866/#review116651
-----------------------------------------------------------


Ship it!




Ship It!

- Anand Mazumdar


On Jan. 27, 2016, 8:38 p.m., Jojy Varghese wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42866/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 8:38 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It has shown flaky behavior and needs further investigation. Disabling now as
> its not a very important test for functionality.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 33df60065903228749833bbad20449ba8784594a 
> 
> Diff: https://reviews.apache.org/r/42866/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>