[jira] [Commented] (OFBIZ-5384) Not need to set shipping info in CheckInits.groovy

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-5384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13813882#comment-13813882 ] 

Jacques Le Roux commented on OFBIZ-5384:
----------------------------------------

Hi Leon,

Please be sure to update your working copy when you create a patch. I recently (at r1538096) fixed the bug using setAllShippingContactMechId.

You say it's useless. This was introduced by Hans with http://svn.apache.org/viewvc?view=revision&revision=1178353. Do you say that it's useless even in the context of this feature? I must say, even after having played with it some minutes, I don't clearly understand how Invitation is supposed to work.

> Not need to set shipping info in CheckInits.groovy
> --------------------------------------------------
>
>                 Key: OFBIZ-5384
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5384
>             Project: OFBiz
>          Issue Type: Bug
>          Components: order
>    Affects Versions: SVN trunk
>            Reporter: Leon
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-5384.patch
>
>
> In the tail of CheckInits.groovy, there're some code to set shipping info of assigned party into shopping cart. But it's not necessary, and the code is buggy (1. check Person only 2. no shoppingCart.setShippingContactMechId(String) method defined).
> So I remove these codes from CheckInits.groovy. Pls see attached patch.



--
This message was sent by Atlassian JIRA
(v6.1#6144)