You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by mh...@apache.org on 2011/03/24 20:15:17 UTC
svn commit: r1085079 - in
/shindig/trunk/features/src/main/javascript/features/container: constant.js
container.js feature.xml
Author: mhermanto
Date: Thu Mar 24 19:15:16 2011
New Revision: 1085079
URL: http://svn.apache.org/viewvc?rev=1085079&view=rev
Log:
Remove common container ContainerRender constants.
http://codereview.appspot.com/4273106/
Modified:
shindig/trunk/features/src/main/javascript/features/container/constant.js
shindig/trunk/features/src/main/javascript/features/container/container.js
shindig/trunk/features/src/main/javascript/features/container/feature.xml
Modified: shindig/trunk/features/src/main/javascript/features/container/constant.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/constant.js?rev=1085079&r1=1085078&r2=1085079&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/constant.js (original)
+++ shindig/trunk/features/src/main/javascript/features/container/constant.js Thu Mar 24 19:15:16 2011
@@ -93,15 +93,75 @@ shindig.container.NavigateTiming.PRT = '
* @enum {string}
*/
shindig.container.RenderParam = {};
+
+/**
+ * Allow gadgets to render in unspecified view.
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.ALLOW_DEFAULT_VIEW = 'allowDefaultView';
+
+/**
+ * Whether to enable cajole mode.
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.CAJOLE = 'cajole';
+
+/**
+ * Style class to associate to iframe.
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.CLASS = 'class';
+
+/**
+ * Whether to enable debugging mode.
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.DEBUG = 'debug';
+
+/**
+ * The starting gadget iframe height (in pixels).
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.HEIGHT = 'height';
+
+/**
+ * Whether to disable cache.
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.NO_CACHE = 'nocache';
+
+/**
+ * Whether to enable test mode.
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.TEST_MODE = 'testmode';
+
+/**
+ * The gadget user prefs to render with.
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.USER_PREFS = 'userPrefs';
+
+/**
+ * The view of gadget to render.
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.VIEW = 'view';
+
+/**
+ * The starting gadget iframe width (in pixels).
+ * @type {string}
+ * @const
+ */
shindig.container.RenderParam.WIDTH = 'width';
Modified: shindig/trunk/features/src/main/javascript/features/container/container.js
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/container.js?rev=1085079&r1=1085078&r2=1085079&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/container.js (original)
+++ shindig/trunk/features/src/main/javascript/features/container/container.js Thu Mar 24 19:15:16 2011
@@ -319,6 +319,12 @@ shindig.container.Container.addMixin = f
*/
shindig.container.ContainerConfig = {};
/**
+ * Allow gadgets to render in unspecified view.
+ * @type {string}
+ * @const
+ */
+shindig.container.ContainerConfig.ALLOW_DEFAULT_VIEW = 'allowDefaultView';
+/**
* Whether cajole mode is turned on.
* @type {string}
* @const
@@ -377,58 +383,6 @@ shindig.container.ContainerConfig.PRELOA
shindig.container.ContainerConfig.PRELOAD_TOKENS = 'preloadTokens';
-/**
- * Enum keys for gadget rendering params. Gadget rendering params affect which
- * view of a gadget of displayed and how the gadget site is rendered, and are
- * not passed on to the actual gadget. These enum values are for documentation
- * purposes only, it is expected that clients use the string values.
- * @enum {string}
- */
-shindig.container.ContainerRender = {};
-/**
- * Allow gadgets to render in unspecified view.
- * @type {string}
- * @const
- */
-shindig.container.ContainerRender.ALLOW_DEFAULT_VIEW = 'allowDefaultView';
-/**
- * Style class to associate to iframe.
- * @type {string}
- * @const
- */
-shindig.container.ContainerRender.CLASS = 'class';
-/**
- * Whether to turn off debugging.
- * @type {string}
- * @const
- */
-shindig.container.ContainerRender.DEBUG = 'debug';
-/**
- * The starting/default gadget iframe height (in pixels).
- * @type {string}
- * @const
- */
-shindig.container.ContainerRender.HEIGHT = 'height';
-/**
- * Whether to turn off debugging.
- * @type {string}
- * @const
- */
-shindig.container.ContainerRender.TEST = 'test';
-/**
- * The gadget view name.
- * @type {string}
- * @const
- */
-shindig.container.ContainerRender.VIEW = 'view';
-/**
- * The starting/default gadget iframe width (in pixels).
- * @type {string}
- * @const
- */
-shindig.container.ContainerRender.WIDTH = 'width';
-
-
// -----------------------------------------------------------------------------
// Private variables and methods.
// -----------------------------------------------------------------------------
Modified: shindig/trunk/features/src/main/javascript/features/container/feature.xml
URL: http://svn.apache.org/viewvc/shindig/trunk/features/src/main/javascript/features/container/feature.xml?rev=1085079&r1=1085078&r2=1085079&view=diff
==============================================================================
--- shindig/trunk/features/src/main/javascript/features/container/feature.xml (original)
+++ shindig/trunk/features/src/main/javascript/features/container/feature.xml Thu Mar 24 19:15:16 2011
@@ -46,6 +46,7 @@ under the License.
<exports type="js">shindig.container.Container.prototype.getGadgetMetadata</exports>
<exports type="js">shindig.container.Container.prototype.rpcRegister</exports>
<exports type="js">shindig.container.Container.prototype.onConstructed</exports>
+ <exports type="js">shindig.container.ContainerConfig.ALLOW_DEFAULT_VIEW</exports>
<exports type="js">shindig.container.ContainerConfig.RENDER_CAJOLE</exports>
<exports type="js">shindig.container.ContainerConfig.RENDER_DEBUG</exports>
<exports type="js">shindig.container.ContainerConfig.RENDER_DEBUG_PARAM</exports>
@@ -55,13 +56,16 @@ under the License.
<exports type="js">shindig.container.ContainerConfig.PRELOAD_REF_TIME</exports>
<exports type="js">shindig.container.ContainerConfig.PRELOAD_METADATAS</exports>
<exports type="js">shindig.container.ContainerConfig.PRELOAD_TOKENS</exports>
- <exports type="js">shindig.container.ContainerRender.ALLOW_DEFAULT_VIEW</exports>
- <exports type="js">shindig.container.ContainerRender.CLASS</exports>
- <exports type="js">shindig.container.ContainerRender.DEBUG</exports>
- <exports type="js">shindig.container.ContainerRender.HEIGHT</exports>
- <exports type="js">shindig.container.ContainerRender.TEST</exports>
- <exports type="js">shindig.container.ContainerRender.VIEW</exports>
- <exports type="js">shindig.container.ContainerRender.WIDTH</exports>
+ <exports type="js">shindig.container.RenderParam.ALLOW_DEFAULT_VIEW</exports>
+ <exports type="js">shindig.container.RenderParam.CAJOLE</exports>
+ <exports type="js">shindig.container.RenderParam.CLASS</exports>
+ <exports type="js">shindig.container.RenderParam.DEBUG</exports>
+ <exports type="js">shindig.container.RenderParam.HEIGHT</exports>
+ <exports type="js">shindig.container.RenderParam.NO_CACHE</exports>
+ <exports type="js">shindig.container.RenderParam.TEST_MODE</exports>
+ <exports type="js">shindig.container.RenderParam.USER_PREFS</exports>
+ <exports type="js">shindig.container.RenderParam.VIEW</exports>
+ <exports type="js">shindig.container.RenderParam.WIDTH</exports>
<exports type="js">shindig.container.GadgetSite.prototype.setHeight</exports>
<exports type="js">shindig.container.GadgetSite.prototype.setWidth</exports>
<exports type="js">shindig.container.GadgetSite.prototype.getId</exports>