You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by mb...@apache.org on 2013/05/15 21:25:31 UTC

svn commit: r1483024 - /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java

Author: mbertozzi
Date: Wed May 15 19:25:31 2013
New Revision: 1483024

URL: http://svn.apache.org/r1483024
Log:
HBASE-8540 SnapshotFileCache logs too many times if snapshot dir doesn't exists

Modified:
    hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java

Modified: hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java
URL: http://svn.apache.org/viewvc/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java?rev=1483024&r1=1483023&r2=1483024&view=diff
==============================================================================
--- hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java (original)
+++ hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/master/snapshot/SnapshotFileCache.java Wed May 15 19:25:31 2013
@@ -188,6 +188,9 @@ public class SnapshotFileCache implement
     try {
       status = fs.getFileStatus(snapshotDir);
     } catch (FileNotFoundException e) {
+      if (this.cache.size() > 0) {
+        LOG.error("Snapshot directory: " + snapshotDir + " doesn't exist");
+      }
       return;
     }
     // if the snapshot directory wasn't modified since we last check, we are done
@@ -209,7 +212,9 @@ public class SnapshotFileCache implement
     FileStatus[] snapshots = FSUtils.listStatus(fs, snapshotDir);
     if (snapshots == null) {
       // remove all the remembered snapshots because we don't have any left
-      LOG.debug("No snapshots on-disk, cache empty");
+      if (LOG.isDebugEnabled() && this.snapshots.size() > 0) {
+        LOG.debug("No snapshots on-disk, cache empty");
+      }
       this.snapshots.clear();
       return;
     }