You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/07/30 07:27:00 UTC
[jira] [Commented] (GEODE-8391) Skip AvailablePort test assertion
if host machine does not support it
[ https://issues.apache.org/jira/browse/GEODE-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167697#comment-17167697 ]
ASF GitHub Bot commented on GEODE-8391:
---------------------------------------
demery-pivotal opened a new pull request #5412:
URL: https://github.com/apache/geode/pull/5412
An assertion in AvailablePortJUnitTest.testIsPortAvailable() assumes
that the InetAddress for the local host is not a loopback address.
Though this assumption holds in our CI containers, it fails on some
developer's Macs, and perhaps on other hosts.
This commit changes the test to skip that assertion if the local host
address is a loopback address.
Authored-by: Dale Emery <de...@vmware.com>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [X] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [X] Is your initial contribution a single, squashed commit?
- [X] Does `gradlew build` run cleanly?
- [X] Have you written or updated unit tests to verify your changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Skip AvailablePort test assertion if host machine does not support it
> ---------------------------------------------------------------------
>
> Key: GEODE-8391
> URL: https://issues.apache.org/jira/browse/GEODE-8391
> Project: Geode
> Issue Type: Test
> Components: tests
> Reporter: Dale Emery
> Priority: Major
> Labels: GeodeOperationAPI
>
> One of the assertions in {{AvailablePortJUnitTest.testIsPortAvailable()}} assumes that the {{InetAddress}} for the local host is not a loopback address. Though this assumption holds in our CI containers, it fails on some developer's Macs.
> Change the test to skip this one assertion if the {{InetAddress}} for the local host is a loopback address.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)