You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2019/05/16 13:25:18 UTC
[mesos] branch 1.8.x updated (3bc6082 -> 1ace477)
This is an automated email from the ASF dual-hosted git repository.
bmahler pushed a change to branch 1.8.x
in repository https://gitbox.apache.org/repos/asf/mesos.git.
from 3bc6082 Enabled launcher sealing for RPM packages.
new d1f25f7 Added logging of slow reverse DNS when accepting SSL connections.
new 1ace477 Added MESOS-9787 to the 1.8.1 CHANGELOG.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../libprocess/src/posix/libevent/libevent_ssl_socket.cpp | 13 +++++++++++++
CHANGELOG | 1 +
2 files changed, 14 insertions(+)
[mesos] 01/02: Added logging of slow reverse DNS when accepting SSL
connections.
Posted by bm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
bmahler pushed a commit to branch 1.8.x
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit d1f25f7b151c73b67a92ed4945acb010b74a34f5
Author: Benjamin Mahler <bm...@apache.org>
AuthorDate: Thu May 16 11:42:26 2019 +0200
Added logging of slow reverse DNS when accepting SSL connections.
Slow reverse DNS lookup is a serious issue since today it is done
synchronously from the event loop thread, see MESOS-9339 and
related tickets. Logging slow requests will substantially improve
debugging.
Review: https://reviews.apache.org/r/70653
---
.../libprocess/src/posix/libevent/libevent_ssl_socket.cpp | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp b/3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp
index bc8f782..29a1bf7 100644
--- a/3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp
+++ b/3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp
@@ -26,6 +26,7 @@
#include <process/ssl/flags.hpp>
#include <stout/net.hpp>
+#include <stout/stopwatch.hpp>
#include <stout/synchronized.hpp>
#include <stout/os/close.hpp>
@@ -1156,7 +1157,19 @@ void LibeventSSLSocketImpl::accept_SSL_callback(AcceptRequest* request)
Option<string> peer_hostname = None();
if (request->ip.isSome()) {
+ Stopwatch watch;
+
+ watch.start();
Try<string> hostname = net::getHostname(request->ip.get());
+ watch.stop();
+
+ // Due to MESOS-9339, a slow reverse DNS lookup will cause
+ // serious issues as it blocks the event loop thread.
+ if (watch.elapsed() > Milliseconds(100)) {
+ LOG(WARNING) << "Reverse DNS lookup for '" << *request->ip << "'"
+ << " took " << watch.elapsed().ms() << "ms"
+ << ", slowness is problematic (see MESOS-9339)";
+ }
if (hostname.isError()) {
VLOG(2) << "Could not determine hostname of peer: "
[mesos] 02/02: Added MESOS-9787 to the 1.8.1 CHANGELOG.
Posted by bm...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
bmahler pushed a commit to branch 1.8.x
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 1ace4776956bcfc8bb37fdcad0f97937afb24a0c
Author: Benjamin Mahler <bm...@apache.org>
AuthorDate: Thu May 16 15:22:32 2019 +0200
Added MESOS-9787 to the 1.8.1 CHANGELOG.
---
CHANGELOG | 1 +
1 file changed, 1 insertion(+)
diff --git a/CHANGELOG b/CHANGELOG
index 2abd945..3ca814f 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -7,6 +7,7 @@ Release Notes - Mesos - Version 1.8.1 (WIP)
* [MESOS-9616] - `Filters.refuse_seconds` declines resources not in offers.
* [MESOS-9695] - Remove the duplicate pid check in Docker containerizer
* [MESOS-9766] - /__processes__ endpoint can hang.
+ * [MESOS-9787] - Low slow SSL (TLS) peer reverse DNS lookup.
Release Notes - Mesos - Version 1.8.0
-------------------------------------