You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/19 08:36:28 UTC

[GitHub] [cloudstack] wido commented on a change in pull request #4576: Fix: Use Q35 chipset for UEFI x86_64

wido commented on a change in pull request #4576:
URL: https://github.com/apache/cloudstack/pull/4576#discussion_r559996950



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2247,8 +2247,8 @@ public LibvirtVMDef createVMFromSpec(final VirtualMachineTO vmTO) {
         if (MapUtils.isNotEmpty(customParams) && customParams.containsKey(GuestDef.BootType.UEFI.toString())) {
             guest.setBootType(GuestDef.BootType.UEFI);
             guest.setBootMode(GuestDef.BootMode.LEGACY);
+            guest.setMachineType("q35");

Review comment:
       I know it's super fun to run on a Pi and people use it to dev with it.
   
   But I think 99,999999% of all CloudStack installations runs on x86_64 CPUs from either Intel or AMD.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org