[GitHub] [incubator-mxnet] hgt312 commented on a change in pull request #17779: [Numpy] FFI Invocation for Unary Ops

[GitBox <gi...@apache.org>]

hgt312 commented on a change in pull request #17779: [Numpy] FFI Invocation for Unary Ops
URL: https://github.com/apache/incubator-mxnet/pull/17779#discussion_r389337182
 
 

 ##########
 File path: python/mxnet/ndarray/numpy/_op.py
 ##########
 @@ -1933,7 +1933,7 @@ def _unary_func_helper(x, fn_array, fn_scalar, out=None, **kwargs):
     if isinstance(x, numeric_types):
         return fn_scalar(x, **kwargs)
     elif isinstance(x, NDArray):
-        return fn_array(x, out=out, **kwargs)
 
 Review comment:
   In fact, these simple unary ops do not support any `kwargs` in MXNet, `kwargs` only need to make scalar's result right and has uniform error handling by using `@wrap_np_unary_func`. So, move `**kwargs` here is a very simple solution.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services