[GitHub] [skywalking-kubernetes] innerpeacez commented on a diff in pull request #115: Add `cert-manager` sub-chart as quick start

["innerpeacez (via GitHub)" <gi...@apache.org>]

innerpeacez commented on code in PR #115:
URL: https://github.com/apache/skywalking-kubernetes/pull/115#discussion_r1147261643


##########
chart/operator/templates/cert.yaml:
##########
@@ -13,12 +13,15 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-{{- if .Values.webhook.enable }}
+{{- if .Values.webhook.enabled }}
 apiVersion: cert-manager.io/v1
 kind: Certificate
 metadata:
   name: {{ include "operator.fullname" . }}-serving-cert
   namespace: {{ .Release.Namespace }}
+  annotations:
+    "helm.sh/hook": post-install,post-upgrade
+    "helm.sh/hook-weight": "1"

Review Comment:
   Issuer
   Certificate
   
   Do different weights to distinguish the execution order?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org