You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/11/16 05:54:44 UTC

[GitHub] [rocketmq] XiaoyiPeng commented on a change in pull request #3490: [ISSUE #3493] DefaultMQPushConsumer#setConsumeThreadMax(int consumeThreadMax) has no effect.

XiaoyiPeng commented on a change in pull request #3490:
URL: https://github.com/apache/rocketmq/pull/3490#discussion_r749927046



##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
##########
@@ -61,14 +61,25 @@
     private final ScheduledExecutorService scheduledExecutorService;
     private final ScheduledExecutorService cleanExpireMsgExecutors;
 
+    /**
+     * The default retry delay in milliseconds when submitting a {@link ConsumeRequest} encounters RejectedExecutionException
+     */
+    private static final int DEFAULT_CONSUME_REQUEST_LATER_DELAY_MILLS = 5000;

Review comment:
       Cannot be configured currently, the previous version was hard-coded with a value of 5000.
   Should I make it configurable?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org