You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/10/20 18:46:00 UTC
[I] Clean up LogEntry class [accumulo]
keith-turner opened a new issue, #3878:
URL: https://github.com/apache/accumulo/issues/3878
The LogEntry class has some technical debt that would be good to cleanup. The following improvements could be made.
* There is a field named filename that actually seems to store a fully qualified path. Could rename this field Could also add validation to this field to ensure its of the expected format.
* There is a field named extent that is only used by unit test, could probably remove this.
* There is no equals or hashCode method, these could be added.
* There is upgrade code in the class that deals with some old format of the data. Can not see any test for this. Could remove if this if adding validation that would fail on seeing this. Could possibly look for this in upgrade and covert,if we can figure out what the old format was. However the old format may be really old and seeing it may be unexpected or not realistically possible.
* The value in the metadata table seems to store the exact same data as the column qualifier. This code could be cleaned up to not store redundant info, may require change in upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Clean up LogEntry class [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on issue #3878:
URL: https://github.com/apache/accumulo/issues/3878#issuecomment-1792396104
Fixed via #3886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Clean up LogEntry class [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on issue #3878:
URL: https://github.com/apache/accumulo/issues/3878#issuecomment-1792401017
Oops I just realized this ticket was marked for 3.1.0 however the PR, 3886 was merged into elasticity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Clean up LogEntry class [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo commented on issue #3878:
URL: https://github.com/apache/accumulo/issues/3878#issuecomment-1773253138
I'll start looking into this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Clean up LogEntry class [accumulo]
Posted by "DomGarguilo (via GitHub)" <gi...@apache.org>.
DomGarguilo closed issue #3878: Clean up LogEntry class
URL: https://github.com/apache/accumulo/issues/3878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org