[GitHub] [avro] RyanSkraba commented on a diff in pull request #2250: AVRO-3760: [python] Fix resolution of future enum with default symbol

["RyanSkraba (via GitHub)" <gi...@apache.org>]

RyanSkraba commented on code in PR #2250:
URL: https://github.com/apache/avro/pull/2250#discussion_r1231338739


##########
lang/py/avro/io.py:
##########
@@ -776,6 +766,9 @@ def read_enum(self, writers_schema: avro.schema.EnumSchema, readers_schema: avro
         # read data
         index_of_symbol = decoder.read_int()
         if index_of_symbol >= len(writers_schema.symbols):
+            default = writers_schema.default

Review Comment:
   From my comment on AVRO-3760 -- if we're a bit more strict, this should probably fail here when there's not a readers_schema.  We should discuss on the JIRA what we actually want to do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org