[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11549: [BEAM-9136] Update doc about docker image license pulling

[GitBox <gi...@apache.org>]

Hannah-Jiang commented on a change in pull request #11549:
URL: https://github.com/apache/beam/pull/11549#discussion_r416821826



##########
File path: CHANGES.md
##########
@@ -122,13 +122,22 @@ conversion to beam schema options. *Remark: Schema aware is still experimental.*
     values as strings) into Python native types that are written to Avro
     (Python's date, datetime types, decimal, etc). For more information
     see https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-avro#avro_conversions.
+* Licenses/notices of third party dependencies are added to Java and Python SDK docker images. ([BEAM-9136](https://issues.apache.org/jira/browse/BEAM-9136))
+    
+    <b>Java SDK images</b>: By default, it checks if the licenses/notices are pullable, instead of pulling the licenses/notices. In order to pull licenses, `docker-pull-licenses` variable should ba passed.
+    
+    <b>Python SDK images</b>: By default, it pulls licenses/notices of the third party licenses.
+    
+    If you want to create lightweight images or do not want to deal with licenses, you can pass `no-licenses` variable when build docker images to skip it.

Review comment:
       yep, correct. The sentence is very likely to be changed. I will add WIP to the title for now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org