[GitHub] [cordova-windows] janpio opened a new pull request #335: Fix wrong (default) description content being written to project files

[GitBox <gi...@apache.org>]

janpio opened a new pull request #335: Fix wrong (default) description content being written to project files
URL: https://github.com/apache/cordova-windows/pull/335
 
 
   ### Motivation and Context
   
   This PR fixes a bug that led to the wrong app description being used for Cordova Windows apps.
   
   The bug was introduced in https://github.com/apache/cordova-windows/pull/254/files#diff-83c0809a5a3967aec365d13bf70b2be3. That change allowed the prepare script to work properly in tests, but broke the logic from the `config.xml` creation logic as I didn't also create a `defaults.xml` file at the same time that was empty and that otherweise would have been used as the initial template to build a `config.xml` from.
   
   ### Description
   
   So this PR creates that missing `defaults.xml` file.
   
   closes #270
   
   ### Testing
   
   I tested this locally by using the platform to create a project and observed that it now uses the correct description in the Cordova Windows project files.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org