You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/10/15 02:18:40 UTC
[GitHub] [shardingsphere] TeslaCN opened a new issue, #21574: Refactor PreparedStatement in ShardingSphere-Proxy
TeslaCN opened a new issue, #21574:
URL: https://github.com/apache/shardingsphere/issues/21574
## Refactor
https://github.com/apache/shardingsphere/blob/00f5553fa3b5ba2b772e9fecb58fe72f6ee4119e/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/session/PreparedStatement.java#L28
The current `PreparedStatement` naming coincides with the JDBC `PreparedStatement`. Consider adjusting the naming and improving the immutability of the implementation class.
- [ ] Rename `PreparedStatement` to `ServerPreparedStatement`.
- [ ] Make all fields of implementations of PreparedStatement final.
- [ ] Wrapping `EmptyStatement` and `DistSQLStatement` into `CommonSQLStatementContext`.
- [ ] Consider moving `String sql` into SQLStatementContext.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on issue #21574: Refactor PreparedStatement in ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on issue #21574:
URL: https://github.com/apache/shardingsphere/issues/21574#issuecomment-1303054137
Step 4 is a big change and is not for ShardingSphere-Proxy only, it may require further discussion. This issue has been finished.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN closed issue #21574: Refactor PreparedStatement in ShardingSphere-Proxy
Posted by GitBox <gi...@apache.org>.
TeslaCN closed issue #21574: Refactor PreparedStatement in ShardingSphere-Proxy
URL: https://github.com/apache/shardingsphere/issues/21574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org