You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/14 12:21:19 UTC
[GitHub] [pulsar-dotpulsar] ddieruf opened a new issue #99: Wondering about proto
ddieruf opened a new issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99
As I learn more about the project, I was wondering how `DotPulsar.Internal.PulsarApi` is generated? To be honest I was expecting to see a github workflow (or some automation) that creates the .cs but I don't (apologies if I missed it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99#issuecomment-1039056022
Hi @ddieruf
It's done using https://protogen.marcgravell.com/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] ddieruf closed issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
ddieruf closed issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99#issuecomment-1039534679
Ah, yes it's here: https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/proto/PulsarApi.proto and we generated the cs-file based on version 281163b of that file (as noted in the cs-file).
I don't know what version of Pulsar that is, but I don't think that matters. They have kept backward compatibility and even though we created the cs-file based on that version, it doesn't mean that all functionality is supported (e.g Transactions).
Hope that answers your question :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] ddieruf commented on issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
ddieruf commented on issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99#issuecomment-1040563851
Yes, thank you. I have to shift my thinking. Because this client is not in parity with the platform, claiming a certain version's compatibility is not useful. Also adding in backward compatibility in the proto further drives that point.
I am used to assuming a client covers all the features of the platform. But that's not always the case, especially in an open source world.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] ddieruf commented on issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
ddieruf commented on issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99#issuecomment-1039090818
Hi, thank you for that. Does the master branch follow the latest version of Pulsar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99#issuecomment-1039101820
Not sure I understand what you mean by that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] ddieruf commented on issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
ddieruf commented on issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99#issuecomment-1039344616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] blankensteiner commented on issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
blankensteiner commented on issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99#issuecomment-1039534679
Ah, yes it's here: https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/proto/PulsarApi.proto and we generated the cs-file based on version 281163b of that file (as noted in the cs-file).
I don't know what version of Pulsar that is, but I don't think that matters. They have kept backward compatibility and even though we created the cs-file based on that version, it doesn't mean that all functionality is supported (e.g Transactions).
Hope that answers your question :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] ddieruf closed issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
ddieruf closed issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-dotpulsar] ddieruf commented on issue #99: Wondering about proto
Posted by GitBox <gi...@apache.org>.
ddieruf commented on issue #99:
URL: https://github.com/apache/pulsar-dotpulsar/issues/99#issuecomment-1039344616
First, please forgive my potential lack of grpc knowledge...
I am making the assumption that the main Pulsar project produces some sort of .proto definition for a client to implement. You are using the above protogen tool to create the .cs implementing it. That definition file is a part of a certain version of Pulsar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org