[jira] [Commented] (JCR-2936) JMX Bindings for Jackrabbit

["Jukka Zitting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015934#comment-13015934 ] 

Jukka Zitting commented on JCR-2936:
------------------------------------

I committed the patch in revision 1089061. Good work!

As you mention, the solution still need some work, so I'm leaving this issue open.

The most notable design issue I have with the current solution is that the JMX code now spills over to other parts of the codebase. A cleaner approach would be to statistics collectors right there with the query manager and other similar places with no JMX dependencies, and have the JMX code simply access that information through the RepositoryContext. Such an approach makes the collected statistics and other runtime information easier to use also for non-JMX purposes.

> JMX Bindings for Jackrabbit
> ---------------------------
>
>                 Key: JCR-2936
>                 URL: https://issues.apache.org/jira/browse/JCR-2936
>             Project: Jackrabbit Content Repository
>          Issue Type: New Feature
>          Components: jackrabbit-core
>            Reporter: Alex Parvulescu
>            Priority: Minor
>         Attachments: JCR-2936.patch
>
>
> There has been a slight interest in the past for adding JMX support.
> This would be the first stab at it. It is a Top 15 slow query log. (the 15 part is configurable)
> It is not enabled by default, so just being there should not affect the overall performance too much. You can enable it and play a little, tell me what you think.
> I've also added a test case that does a duration comparison with and without the logger.
> The most important part of this issue is that it should open the way for some proper monitoring tools support around queries, caches, anything/everything Jackrabbit.
> As usual, please let me know what you guys think

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira