You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 00:52:05 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #1567: Fix incorrect buffers for UnionArray
viirya opened a new pull request, #1567:
URL: https://github.com/apache/arrow-rs/pull/1567
# Which issue does this PR close?
<!---
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #1547.
# Rationale for this change
<!---
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!---
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!---
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1567: Fix incorrect `into_buffers` for UnionArray
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1567:
URL: https://github.com/apache/arrow-rs/pull/1567#discussion_r850614718
##########
arrow/src/array/data.rs:
##########
@@ -2594,4 +2600,21 @@ mod tests {
assert_eq!(&struct_array_slice, &cloned);
}
+
+ #[test]
+ fn test_into_buffers() {
+ let data_types = vec![
+ DataType::Union(vec![], UnionMode::Sparse),
+ DataType::Union(vec![], UnionMode::Sparse),
+ ];
Review Comment:
We can add more datatypes if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1567: Fix incorrect `into_buffers` for UnionArray
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1567:
URL: https://github.com/apache/arrow-rs/pull/1567#issuecomment-1099526699
Thank you @tustvold !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #1567: Fix incorrect `into_buffers` for UnionArray
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #1567:
URL: https://github.com/apache/arrow-rs/pull/1567#discussion_r850670109
##########
arrow/src/compute/kernels/filter.rs:
##########
@@ -1692,9 +1692,6 @@ mod tests {
}
#[test]
- // Fails when validation enabled
- // https://github.com/apache/arrow-rs/issues/1547
- #[cfg(not(feature = "force_validate"))]
fn test_filter_union_array_sparse() {
Review Comment:
Re-enabled them here. cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1567: Fix incorrect `into_buffers` for UnionArray
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1567:
URL: https://github.com/apache/arrow-rs/pull/1567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #1567: Fix incorrect `into_buffers` for UnionArray
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1567:
URL: https://github.com/apache/arrow-rs/pull/1567#issuecomment-1098615507
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1567?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1567](https://codecov.io/gh/apache/arrow-rs/pull/1567?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d24bae3) into [master](https://codecov.io/gh/apache/arrow-rs/commit/eb6b7c65f49794f54d9b11a632172ffa13783ff2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb6b7c6) will **increase** coverage by `0.08%`.
> The diff coverage is `80.00%`.
```diff
@@ Coverage Diff @@
## master #1567 +/- ##
==========================================
+ Coverage 82.76% 82.84% +0.08%
==========================================
Files 190 190
Lines 54702 54988 +286
==========================================
+ Hits 45272 45555 +283
- Misses 9430 9433 +3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/1567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/array/data.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L2RhdGEucnM=) | `83.24% <80.00%> (+0.44%)` | :arrow_up: |
| [arrow/src/alloc/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FsbG9jL21vZC5ycw==) | `78.04% <0.00%> (-13.38%)` | :arrow_down: |
| [arrow/src/buffer/immutable.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2J1ZmZlci9pbW11dGFibGUucnM=) | `98.48% <0.00%> (-0.97%)` | :arrow_down: |
| [arrow/src/datatypes/field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2RhdGF0eXBlcy9maWVsZC5ycw==) | `53.79% <0.00%> (-0.31%)` | :arrow_down: |
| [parquet\_derive/src/parquet\_field.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldF9kZXJpdmUvc3JjL3BhcnF1ZXRfZmllbGQucnM=) | `65.98% <0.00%> (-0.23%)` | :arrow_down: |
| [arrow/src/record\_batch.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3JlY29yZF9iYXRjaC5ycw==) | `93.99% <0.00%> (-0.02%)` | :arrow_down: |
| [arrow/src/array/mod.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2FycmF5L21vZC5ycw==) | `100.00% <0.00%> (ø)` | |
| [arrow/src/util/data\_gen.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL3V0aWwvZGF0YV9nZW4ucnM=) | `75.44% <0.00%> (ø)` | |
| [arrow/src/buffer/mutable.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2J1ZmZlci9tdXRhYmxlLnJz) | `90.53% <0.00%> (ø)` | |
| [parquet/src/arrow/schema.rs](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGFycXVldC9zcmMvYXJyb3cvc2NoZW1hLnJz) | `85.68% <0.00%> (ø)` | |
| ... and [16 more](https://codecov.io/gh/apache/arrow-rs/pull/1567/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1567?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1567?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [eb6b7c6...d24bae3](https://codecov.io/gh/apache/arrow-rs/pull/1567?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a diff in pull request #1567: Fix incorrect `into_buffers` for UnionArray
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #1567:
URL: https://github.com/apache/arrow-rs/pull/1567#discussion_r850750862
##########
arrow/src/compute/kernels/filter.rs:
##########
@@ -1692,9 +1692,6 @@ mod tests {
}
#[test]
- // Fails when validation enabled
- // https://github.com/apache/arrow-rs/issues/1547
- #[cfg(not(feature = "force_validate"))]
fn test_filter_union_array_sparse() {
Review Comment:
❤️ so nice -- thank you @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #1567: Fix incorrect `into_buffers` for UnionArray
Posted by GitBox <gi...@apache.org>.
viirya commented on PR #1567:
URL: https://github.com/apache/arrow-rs/pull/1567#issuecomment-1099347328
Thanks @tustvold . Okay, I will add a test for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org