[jira] [Commented] (BOOKKEEPER-630) Resolve inconsistency between o.a.b.net.* and o.a.b.util.net.*

["Ivan Kelly (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13686591#comment-13686591 ] 

Ivan Kelly commented on BOOKKEEPER-630:
---------------------------------------

I've just seen that I actually put DNS is a different package than [~hustlmsp] did in the rack awareness patch. We should put them both in one place. Also, he changed indentation whereas I did not. We should agree on one and fixup the files as necessary. Also, I tagged the files with the version I copied from. All the files should have this.

So, I've renamed the patch to make these fixups once they're decided. My votes on the matters are.

* No preference on package name.
* No indentation changes, for the reasons given above.


                
> Resolve inconsistency between o.a.b.net.* and o.a.b.util.net.*
> --------------------------------------------------------------
>
>                 Key: BOOKKEEPER-630
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-630
>             Project: Bookkeeper
>          Issue Type: Improvement
>            Reporter: Flavio Junqueira
>            Priority: Trivial
>
> We didn't reformat the code before bringing it in from hadoop commons in the patch of BOOKKEEPER-618.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira