You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/14 00:17:06 UTC
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning opened a new issue, #8: need to review if we can remove ojdbc6 jar
pjfanning opened a new issue, #8:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/8
* we should not have jars checked in
* we can get the build to script to download the jar from an external web site, if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on issue #8: need to review if we can remove ojdbc6 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #8:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/8#issuecomment-1506591024
Ah I understand now, we literally have `ojdbc6.jar` as a file checked out in this repo. Isn't the easiest solution to just resolve the jar from maven https://mvnrepository.com/artifact/oracle/ojdbc6/11.2.0.4.0 in test scope like we would do with any other jar that is used for testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on issue #8: need to review if we can remove ojdbc6 jar
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #8:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/8#issuecomment-1506555918
@mdedetrich I haven't investigated why the jar is checked in. It is likely to be there for testing. We can not release a source release that includes this jar.
* we can include binaries in source releases
* I believe that this jar in particular has a license that is not compatible with Apache's
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on issue #8: need to review if we can remove ojdbc6 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #8:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/8#issuecomment-1506581345
Ah I realized that this is the oracle JDBC driver which means that indeed we do have to use it if we want to test against oracle, but since its a jar it is considered to be a binary and not a source release right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on issue #8: need to review if we can remove ojdbc6 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #8:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/8#issuecomment-1506479524
@pjfanning Is this just used for testing? If so we can use testcontainers which has an oracle image and that way I don't think we will be breaking any licensing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on issue #8: need to review if we can remove ojdbc6 jar
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #8:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/8#issuecomment-1506587391
We must support a source release - ASF requirements.
We can obviously do something with sbt-source-dist to exclude jars. But then any attempt to run the build after unzipping the source zip will be liable to fail because of the missing jar.
One solution is simply to remove the jar from git altogetehr and to rewrite the build script so that it downloods the ojdbc jar. I do not know why this jar isn't currently downloaded using libraryDependencies in the sbt files already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on issue #8: need to review if we can remove ojdbc6 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #8:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/8#issuecomment-1506639822
PR made here https://github.com/apache/incubator-pekko-persistence-jdbc/pull/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich closed issue #8: need to review if we can remove ojdbc6 jar
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #8: need to review if we can remove ojdbc6 jar
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/issues/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org