You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/08/21 15:45:37 UTC
Review Request 37678: Downgrades That Are Retried With Unhealthy
Hosts Can Produce Multiple Stages In Progress
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37678/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Robert Levas, and Robert Nettleton.
Bugs: AMBARI-12850
https://issues.apache.org/jira/browse/AMBARI-12850
Repository: ambari
Description
-------
When performing a downgrade from HDP 2.3 to HDP 2.2, the web client can sometimes not show the Retry button in the event of a failure. The problem stems from two issues:
- When retrying a stage with hosts not heartbeating, the entire stage is automatically aborted
- Task updates in stages is done in a non-atomic manner.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeGroupService.java ed97d66
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 67379ee
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java 468315b
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 351bbec
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 0f05140
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 83c2c44
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 1f8bf8d
ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 63f015b
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java 4516b34
Diff: https://reviews.apache.org/r/37678/diff/
Testing
-------
Tests run: 3159, Failures: 0, Errors: 0, Skipped: 25
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 23:26 min
[INFO] Finished at: 2015-08-20T22:55:58-04:00
[INFO] Final Memory: 48M/1069M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 37678: Downgrades That Are Retried With Unhealthy
Hosts Can Produce Multiple Stages In Progress
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37678/#review96052
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Aug. 21, 2015, 1:45 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37678/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 1:45 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, and Robert Nettleton.
>
>
> Bugs: AMBARI-12850
> https://issues.apache.org/jira/browse/AMBARI-12850
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing a downgrade from HDP 2.3 to HDP 2.2, the web client can sometimes not show the Retry button in the event of a failure. The problem stems from two issues:
>
> - When retrying a stage with hosts not heartbeating, the entire stage is automatically aborted
> - Task updates in stages is done in a non-atomic manner.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeGroupService.java ed97d66
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 67379ee
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java 468315b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 351bbec
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 0f05140
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 83c2c44
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 1f8bf8d
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 63f015b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java 4516b34
>
> Diff: https://reviews.apache.org/r/37678/diff/
>
>
> Testing
> -------
>
> Tests run: 3159, Failures: 0, Errors: 0, Skipped: 25
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:26 min
> [INFO] Finished at: 2015-08-20T22:55:58-04:00
> [INFO] Final Memory: 48M/1069M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 37678: Downgrades That Are Retried With Unhealthy
Hosts Can Produce Multiple Stages In Progress
Posted by Robert Levas <rl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37678/#review96041
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Levas
On Aug. 21, 2015, 9:45 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37678/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2015, 9:45 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Robert Levas, and Robert Nettleton.
>
>
> Bugs: AMBARI-12850
> https://issues.apache.org/jira/browse/AMBARI-12850
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When performing a downgrade from HDP 2.3 to HDP 2.2, the web client can sometimes not show the Retry button in the event of a failure. The problem stems from two issues:
>
> - When retrying a stage with hosts not heartbeating, the entire stage is automatically aborted
> - Task updates in stages is done in a non-atomic manner.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/UpgradeGroupService.java ed97d66
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StageResourceProvider.java 67379ee
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeGroupResourceProvider.java 468315b
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeItemResourceProvider.java 351bbec
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java 0f05140
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java 83c2c44
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 1f8bf8d
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java 63f015b
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StageResourceProviderTest.java 4516b34
>
> Diff: https://reviews.apache.org/r/37678/diff/
>
>
> Testing
> -------
>
> Tests run: 3159, Failures: 0, Errors: 0, Skipped: 25
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23:26 min
> [INFO] Finished at: 2015-08-20T22:55:58-04:00
> [INFO] Final Memory: 48M/1069M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>