[jira] [Commented] (ARTEMIS-1575) configuring custom brokerPlugins within the broker.xml

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311125#comment-16311125 ] 

ASF GitHub Bot commented on ARTEMIS-1575:
-----------------------------------------

Github user pgfox commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1743
  
    @michaelandrepearce  suggested changes made. 
    
    I defined an element "property" around the complex type and reused it in both places.  The element definition baked in the naming convention so the parsing code was a little easier/robust. 
    
    I updated the bit that where already in /artemis-tools/src/test/resources/artemis-configuration.xsd . 
    There seems to be some structure missing from that file. Not sure if it is an oversight or intended.
    
    



> configuring custom brokerPlugins within the broker.xml
> ------------------------------------------------------
>
>                 Key: ARTEMIS-1575
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1575
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>          Components: Broker
>    Affects Versions: 2.4.0
>            Reporter: Pat Fox
>            Priority: Minor
>
> It would be nice to allow users to users configure their custom plugins within the broker.xml, using key value properties like below:  
> {code}
>  <broker-plugins>
>          <broker-plugin class-name="some.custom.Plugin">
>             <plugin-property key="key1" value="value1" />
>             <plugin-property key="key2" value="value2" />
>             <plugin-property key="key3" value="value3" />
>          </broker-plugin>
> </broker-plugins>
> {code} 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)