You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/12/20 19:11:54 UTC

[GitHub] [netbeans] mbien opened a new pull request, #5126: readme update

mbien opened a new pull request, #5126:
URL: https://github.com/apache/netbeans/pull/5126

    - remove travis badge
    - update to build notes and bug report link
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on a diff in pull request #5126: readme update

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on code in PR #5126:
URL: https://github.com/apache/netbeans/pull/5126#discussion_r1055761497


##########
README.md:
##########
@@ -54,21 +52,26 @@ Build with the default config (See the [cluster.config](https://github.com/apach
 ```
 $ ant
 ```
-Build the basic project (mainly, JavaSE features):
+Build the basic project (mainly Java features):
 ```
 $ ant -Dcluster.config=basic
 ```
-Build the full project (including Groovy, PHP, JavaEE/JakartaEE, and JavaScript features):
+Build the full project (including Groovy, PHP, JavaEE/JakartaEE and JavaScript features):
 ```
 $ ant -Dcluster.config=full
 ```
 Build the NetBeans Platform:
 ```
 $ ant -Dcluster.config=platform
 ```
+Cleanup:
+```
+$ ant -q clean

Review Comment:
   I would also mention `git clean -xdf` which sometimes provides faster and "cleaner" result.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on a diff in pull request #5126: readme update

Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5126:
URL: https://github.com/apache/netbeans/pull/5126#discussion_r1055767962


##########
README.md:
##########
@@ -54,21 +52,26 @@ Build with the default config (See the [cluster.config](https://github.com/apach
 ```
 $ ant
 ```
-Build the basic project (mainly, JavaSE features):
+Build the basic project (mainly Java features):
 ```
 $ ant -Dcluster.config=basic
 ```
-Build the full project (including Groovy, PHP, JavaEE/JakartaEE, and JavaScript features):
+Build the full project (including Groovy, PHP, JavaEE/JakartaEE and JavaScript features):
 ```
 $ ant -Dcluster.config=full
 ```
 Build the NetBeans Platform:
 ```
 $ ant -Dcluster.config=platform
 ```
+Cleanup:
+```
+$ ant -q clean

Review Comment:
   i thought about this. But this is more of a git trick and has not much to do with the NetBeans project IMO.
   
   If we wanted to support it we should call it from ant, like: `ant reset-workspace` which would be also self explanatory that it is a quite dangerous ant goal.
   
   git clean is no joke. It cleans your sources and everything else too. `ant clean` is for the build (assuming it works).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni commented on a diff in pull request #5126: readme update

Posted by GitBox <gi...@apache.org>.
ebarboni commented on code in PR #5126:
URL: https://github.com/apache/netbeans/pull/5126#discussion_r1062273815


##########
README.md:
##########
@@ -54,21 +52,26 @@ Build with the default config (See the [cluster.config](https://github.com/apach
 ```
 $ ant
 ```
-Build the basic project (mainly, JavaSE features):
+Build the basic project (mainly Java features):
 ```
 $ ant -Dcluster.config=basic
 ```
-Build the full project (including Groovy, PHP, JavaEE/JakartaEE, and JavaScript features):
+Build the full project (including Groovy, PHP, JavaEE/JakartaEE and JavaScript features):
 ```
 $ ant -Dcluster.config=full
 ```
 Build the NetBeans Platform:
 ```
 $ ant -Dcluster.config=platform
 ```
+Cleanup:
+```
+$ ant -q clean

Review Comment:
   is there a way to clean the external ? I often had the issue of remaining jar file in external that pollute build.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien merged pull request #5126: readme update

Posted by GitBox <gi...@apache.org>.
mbien merged PR #5126:
URL: https://github.com/apache/netbeans/pull/5126


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on a diff in pull request #5126: readme update

Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #5126:
URL: https://github.com/apache/netbeans/pull/5126#discussion_r1062277225


##########
README.md:
##########
@@ -54,21 +52,26 @@ Build with the default config (See the [cluster.config](https://github.com/apach
 ```
 $ ant
 ```
-Build the basic project (mainly, JavaSE features):
+Build the basic project (mainly Java features):
 ```
 $ ant -Dcluster.config=basic
 ```
-Build the full project (including Groovy, PHP, JavaEE/JakartaEE, and JavaScript features):
+Build the full project (including Groovy, PHP, JavaEE/JakartaEE and JavaScript features):
 ```
 $ ant -Dcluster.config=full
 ```
 Build the NetBeans Platform:
 ```
 $ ant -Dcluster.config=platform
 ```
+Cleanup:
+```
+$ ant -q clean

Review Comment:
   don't think there is a target for that. I added a external clean target for nb-javac (#3392) since this would horribly break the build if it uses wrong jars (lost at least a hour on that trying to find the issue). 
   
   But nothing else cleans the ext folder. Would be a good idea though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists