You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/07 14:39:41 UTC
[GitHub] [spark] bjornjorgensen opened a new pull request #35755: [SPARK-38436][PYTHON][TESTS] Change floor to ceil
bjornjorgensen opened a new pull request #35755:
URL: https://github.com/apache/spark/pull/35755
### What changes were proposed in this pull request?
We have two functions that are testing the same thing.
### Why are the changes needed?
To test both floor and ceil.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Got the green light.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35755: [SPARK-38436][PYTHON][TESTS] Change floor to ceil
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35755:
URL: https://github.com/apache/spark/pull/35755#issuecomment-1060918790
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #35755: [SPARK-38436][PYTHON][TESTS] Change floor to ceil
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #35755:
URL: https://github.com/apache/spark/pull/35755#issuecomment-1061013163
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35755: [SPARK-38436][PYTHON][TESTS] Fix `test_ceil` to test `ceil`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35755:
URL: https://github.com/apache/spark/pull/35755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org