You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "jsoref (via GitHub)" <gi...@apache.org> on 2023/09/28 23:19:18 UTC

[GitHub] [superset] jsoref opened a new pull request, #25455: chore(helm): spelling: initialize

jsoref opened a new pull request, #25455:
URL: https://github.com/apache/superset/pull/25455

   <!---
   Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] jsoref commented on pull request #25455: chore(helm): spelling: initialize

Posted by "jsoref (via GitHub)" <gi...@apache.org>.
jsoref commented on PR #25455:
URL: https://github.com/apache/superset/pull/25455#issuecomment-1741247886

   I couldn't figure out how, it wasn't obvious. If you explain, I might have ~5mins today, otherwise Monday.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] craig-rueda commented on pull request #25455: chore(helm): spelling: initialize

Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #25455:
URL: https://github.com/apache/superset/pull/25455#issuecomment-1741267382

   Please run `helm-docs` against the helm folder (https://github.com/norwoodj/helm-docs#installation)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] john-bodley commented on pull request #25455: chore(helm): spelling: initialize

Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #25455:
URL: https://github.com/apache/superset/pull/25455#issuecomment-1741233977

   Thanks @jsoref for the change. Would you mind fixing the failed CI check?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] chore(helm): spelling: initialize [superset]

Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda merged PR #25455:
URL: https://github.com/apache/superset/pull/25455


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org