You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Lucas Machado (JIRA)" <de...@myfaces.apache.org> on 2007/06/18 16:20:26 UTC
[jira] Created: (TOMAHAWK-1027) JScookmenu is generating malformed
HTML when usign ThemeOffice theme
JScookmenu is generating malformed HTML when usign ThemeOffice theme
--------------------------------------------------------------------
Key: TOMAHAWK-1027
URL: https://issues.apache.org/jira/browse/TOMAHAWK-1027
Project: MyFaces Tomahawk
Issue Type: Bug
Components: JS Cook Menu
Affects Versions: 1.1.6
Environment: Mozilla Firefox 2.0
Reporter: Lucas Machado
When usign JS cook menu with ThemeOffice the default implementation generates malformed HTML when the menu have sub-menu itens.
In the generated HTML is missing some </td>
I fix this problem changing the line 195 of JSCookMenu.js from
str += '<td class="' + classStr + 'Text">' + item[1];
to
str += '</td><td class="' + classStr + 'Text">' + item[1] +"</td>";
I did not test it on all possible cenarios. but this change seems to perform well.
This is specially bad when using facelets that require XHTML. As the XHTML is mandatory to be a wellformed HTML Firefox halts the execution of the script when it tries to print the result
on line 321 obj.innerHTML = str;
Apparently Internet Explorer doesn´t check HTML generated by Javascript and the menu works fine even on facelets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TOMAHAWK-1027) JScookmenu is generating malformed
HTML when usign ThemeOffice theme
Posted by "Cagatay Civici (JIRA)" <de...@myfaces.apache.org>.
[ https://issues.apache.org/jira/browse/TOMAHAWK-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cagatay Civici resolved TOMAHAWK-1027.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.1.7-SNAPSHOT
> JScookmenu is generating malformed HTML when usign ThemeOffice theme
> --------------------------------------------------------------------
>
> Key: TOMAHAWK-1027
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1027
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: JS Cook Menu
> Affects Versions: 1.1.6
> Environment: Mozilla Firefox 2.0
> Reporter: Lucas Machado
> Assignee: Cagatay Civici
> Fix For: 1.1.7-SNAPSHOT
>
>
> When usign JS cook menu with ThemeOffice the default implementation generates malformed HTML when the menu have sub-menu itens.
> In the generated HTML is missing some </td>
> I fix this problem changing the line 195 of JSCookMenu.js from
> str += '<td class="' + classStr + 'Text">' + item[1];
> to
> str += '</td><td class="' + classStr + 'Text">' + item[1] +"</td>";
> I did not test it on all possible cenarios. but this change seems to perform well.
> This is specially bad when using facelets that require XHTML. As the XHTML is mandatory to be a wellformed HTML Firefox halts the execution of the script when it tries to print the result
> on line 321 obj.innerHTML = str;
> Apparently Internet Explorer doesn´t check HTML generated by Javascript and the menu works fine even on facelets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.