You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "socutes (via GitHub)" <gi...@apache.org> on 2023/03/08 12:57:20 UTC
[GitHub] [rocketmq] socutes opened a new pull request, #6288: [ISSUE #6287] Fixed two redundant judgments
socutes opened a new pull request, #6288:
URL: https://github.com/apache/rocketmq/pull/6288
close #6287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6288: [ISSUE #6287] Fixed two redundant judgments
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6288:
URL: https://github.com/apache/rocketmq/pull/6288#issuecomment-1463323770
## [Codecov](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6288](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7eaf284) into [develop](https://codecov.io/gh/apache/rocketmq/commit/9e0fb1b0293aebbe5019e55c0fdbd356611b3d16?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e0fb1b) will **increase** coverage by `0.03%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## develop #6288 +/- ##
=============================================
+ Coverage 43.12% 43.16% +0.03%
- Complexity 8847 8861 +14
=============================================
Files 1095 1094 -1
Lines 77279 77283 +4
Branches 10082 10084 +2
=============================================
+ Hits 33324 33356 +32
+ Misses 39782 39757 -25
+ Partials 4173 4170 -3
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/rocketmq/common/utils/ThreadUtils.java](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvVGhyZWFkVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../apache/rocketmq/proxy/grpc/GrpcServerBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvR3JwY1NlcnZlckJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/rocketmq/proxy/grpc/v2/common/GrpcConverter.java](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L2dycGMvdjIvY29tbW9uL0dycGNDb252ZXJ0ZXIuamF2YQ==) | `69.67% <ø> (ø)` | |
| [...mq/client/impl/producer/DefaultMQProducerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9wcm9kdWNlci9EZWZhdWx0TVFQcm9kdWNlckltcGwuamF2YQ==) | `46.03% <25.00%> (-0.20%)` | :arrow_down: |
| [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `51.56% <66.66%> (+2.33%)` | :arrow_up: |
| [...e/rocketmq/broker/topic/TopicRouteInfoManager.java](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvdG9waWMvVG9waWNSb3V0ZUluZm9NYW5hZ2VyLmphdmE=) | `17.79% <100.00%> (-0.70%)` | :arrow_down: |
| [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `69.18% <100.00%> (+2.26%)` | :arrow_up: |
| [...e/rocketmq/remoting/netty/NettyRemotingClient.java](https://codecov.io/gh/apache/rocketmq/pull/6288?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `39.69% <100.00%> (-0.95%)` | :arrow_down: |
... and [37 files with indirect coverage changes](https://codecov.io/gh/apache/rocketmq/pull/6288/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] socutes commented on pull request #6288: [ISSUE #6287] Fixed two redundant judgments
Posted by "socutes (via GitHub)" <gi...@apache.org>.
socutes commented on PR #6288:
URL: https://github.com/apache/rocketmq/pull/6288#issuecomment-1463022086
@xdkxlk PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zhouxinyu merged pull request #6288: [ISSUE #6287] Fixed two redundant judgments
Posted by "zhouxinyu (via GitHub)" <gi...@apache.org>.
zhouxinyu merged PR #6288:
URL: https://github.com/apache/rocketmq/pull/6288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] zhouxinyu commented on a diff in pull request #6288: [ISSUE #6287] Fixed two redundant judgments
Posted by "zhouxinyu (via GitHub)" <gi...@apache.org>.
zhouxinyu commented on code in PR #6288:
URL: https://github.com/apache/rocketmq/pull/6288#discussion_r1131914244
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/v2/common/GrpcConverter.java:
##########
@@ -143,9 +143,8 @@ protected SystemProperties buildSystemProperties(MessageExt messageExt) {
if (uniqKey == null) {
uniqKey = messageExt.getMsgId();
}
- if (uniqKey != null) {
- systemPropertiesBuilder.setMessageId(uniqKey);
- }
+
+ systemPropertiesBuilder.setMessageId(uniqKey);
Review Comment:
It is also possible to return null for messageExt.getMsgId()?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org