You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/08/25 08:34:30 UTC
[jira] [Commented] (HBASE-3229) Table creation, though using
"async" call to master, can actually run for a while and cause RPC timeout
[ https://issues.apache.org/jira/browse/HBASE-3229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13090813#comment-13090813 ]
jiraposter@reviews.apache.org commented on HBASE-3229:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1653/
-----------------------------------------------------------
(Updated 2011-08-25 06:33:04.297176)
Review request for hbase.
Summary
-------
1. Make createTable truly async.
2. Fix up some incorrect comments, logs.
This addresses bug HBASE-3229.
https://issues.apache.org/jira/browse/HBASE-3229
Diffs (updated)
-----
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java 1161360
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java 1161360
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/executor/ExecutorService.java 1161360
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java 1161360
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java 1161360
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/CreateTableHandler.java PRE-CREATION
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/EnableTableHandler.java 1161360
http://svn.apache.org/repos/asf/hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKTable.java 1161360
http://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java 1161360
Diff: https://reviews.apache.org/r/1653/diff
Testing
-------
1. add a new test case to verify RPC timeout exception is gone when creating table with lots of regions.
2. hbase shell, unit tests.
Thanks,
Ming
> Table creation, though using "async" call to master, can actually run for a while and cause RPC timeout
> -------------------------------------------------------------------------------------------------------
>
> Key: HBASE-3229
> URL: https://issues.apache.org/jira/browse/HBASE-3229
> Project: HBase
> Issue Type: Bug
> Components: client, master
> Affects Versions: 0.90.0
> Reporter: Jonathan Gray
> Assignee: Ming Ma
> Priority: Critical
> Fix For: 0.92.0
>
>
> Our create table methods in HBaseAdmin are synchronous from client POV. However, underneath, we're using an "async" create and then looping waiting for table availability. Because the create is async and we loop instead of block on RPC, we don't expect RPC timeouts.
> However, when creating a table with lots of initial regions, the "async" create can actually take a long time (more than 30 seconds in this case) which causes the client to timeout and gives impression something failed.
> We should make the create truly async so that this can't happen. And rather than doing one-off, inline assignment as it is today, we should reuse the fancy enable/disable code stack just added to make this faster and more optimal.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira