You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by GitBox <gi...@apache.org> on 2020/08/04 19:45:58 UTC

[GitHub] [maven-site] elharo opened a new pull request #191: docs: system dependencies are not always available

elharo opened a new pull request #191:
URL: https://github.com/apache/maven-site/pull/191


   @michael-o


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] [maven-site] michael-o commented on a change in pull request #191: docs: system dependencies are not always available

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r465335645



##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism
    unit tests (src/test/java) but not in the model code (src/main/java).
 
  * <<system>>\
-   This scope is similar to <<<provided>>> except that you have to provide the JAR
-   which contains it explicitly. The artifact is always available and is not
-   looked up in a repository.
+   Maven does not add system-scoped dependencies to any classpath.

Review comment:
       I don't see the maybe in the modified text.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] [maven-site] elharo commented on a change in pull request #191: docs: system dependencies are not always available

Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r465334195



##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism
    unit tests (src/test/java) but not in the model code (src/main/java).
 
  * <<system>>\
-   This scope is similar to <<<provided>>> except that you have to provide the JAR
-   which contains it explicitly. The artifact is always available and is not
-   looked up in a repository.
+   Maven does not add system-scoped dependencies to any classpath.

Review comment:
       The keyword is "maybe". There's no guarantee it is, and the current text makes it sound like this is guaranteed. The case that made me pay attention to this was Guava doing a complicated dance to load src.zip for use in javaDoc:
   
   ```
      <profile>
         <id>srczip-parent</id>
         <activation>
           <file>
             <exists>${java.home}/../src.zip</exists>
           </file>
         </activation>
         <dependencies>
           <dependency>
             <groupId>jdk</groupId>
             <artifactId>srczip</artifactId>
             <version>999</version>
             <scope>system</scope>
             <systemPath>${java.home}/../src.zip</systemPath>
             <optional>true</optional>
           </dependency>
         </dependencies>
       </profile>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] [maven-site] michael-o commented on a change in pull request #191: docs: system dependencies are not always available

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r465314300



##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism
    unit tests (src/test/java) but not in the model code (src/main/java).
 
  * <<system>>\
-   This scope is similar to <<<provided>>> except that you have to provide the JAR
-   which contains it explicitly. The artifact is always available and is not
-   looked up in a repository.
+   Maven does not add system-scoped dependencies to any classpath.

Review comment:
       But at least for compilation purposes it is in the classpath or maybe at runtime available.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] [maven-site] elharo commented on a change in pull request #191: docs: system dependencies are not always available

Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r468747113



##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism
    unit tests (src/test/java) but not in the model code (src/main/java).
 
  * <<system>>\
-   This scope is similar to <<<provided>>> except that you have to provide the JAR
-   which contains it explicitly. The artifact is always available and is not
-   looked up in a repository.
+   Maven does not add system-scoped dependencies to any classpath.

Review comment:
       I was referring to the "maybe"in your comment. :-)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] [maven-site] elharo commented on a change in pull request #191: docs: system dependencies are not always available

Posted by GitBox <gi...@apache.org>.
elharo commented on a change in pull request #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r465312675



##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism
    unit tests (src/test/java) but not in the model code (src/main/java).
 
  * <<system>>\
-   This scope is similar to <<<provided>>> except that you have to provide the JAR
-   which contains it explicitly. The artifact is always available and is not
-   looked up in a repository.
+   Maven does not add system-scoped dependencies to any classpath.

Review comment:
       They're usually (though not always) in the classpath but Maven doesn't put them there. The JVM (or something else) does. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] [maven-site] michael-o commented on a change in pull request #191: docs: system dependencies are not always available

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r465301282



##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -172,9 +172,10 @@ Introduction to the Dependency Mechanism
    unit tests (src/test/java) but not in the model code (src/main/java).
 
  * <<system>>\
-   This scope is similar to <<<provided>>> except that you have to provide the JAR
-   which contains it explicitly. The artifact is always available and is not
-   looked up in a repository.
+   Maven does not add system-scoped dependencies to any classpath.

Review comment:
       If it is not added to a classpath, what's the point in having them?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[GitHub] [maven-site] michael-o commented on a change in pull request #191: docs: system dependencies are not always available

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r549468517



##########
File path: content/apt/guides/introduction/introduction-to-dependency-mechanism.apt
##########
@@ -174,9 +174,10 @@ Introduction to the Dependency Mechanism
    unit tests (src/test/java) but not in the model code (src/main/java).
 
  * <<system>>\
-   This scope is similar to <<<provided>>> except that you have to provide the JAR
-   which contains it explicitly. The artifact is always available and is not
-   looked up in a repository.
+   Maven does not add system-scoped dependencies to any classpath.

Review comment:
       I fo not agree with this. @rfscholte 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org